From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_error: blank out reservation conflict printk
Date: Tue, 01 Jun 2010 02:24:57 -0700 [thread overview]
Message-ID: <1275384297.22825.13.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20100601091918.890EB2A3AD@ochil.suse.de>
On Tue, 2010-06-01 at 11:19 +0200, Hannes Reinecke wrote:
> When using SCSI reservations a 'reservation conflict' error
> is actually expected. So we should better use the normal
> SCSI_LOG_XXX functions to make it configurable for those
> cases where we're actually interested in the error.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index a5d630f..def540d 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -1509,8 +1509,8 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
> return SUCCESS;
>
> case RESERVATION_CONFLICT:
> - sdev_printk(KERN_INFO, scmd->device,
> - "reservation conflict\n");
> + SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, scmd->device,
> + "reservation conflict\n"));
> return SUCCESS; /* causes immediate i/o error */
> default:
> return FAILED;
Makes perfect sense to me.
:-)
Acked-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
prev parent reply other threads:[~2010-06-01 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 9:19 [PATCH] scsi_error: blank out reservation conflict printk Hannes Reinecke
2010-06-01 9:24 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275384297.22825.13.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=James.Bottomley@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).