* [PATCH] scsi_error: blank out reservation conflict printk
@ 2010-06-01 9:19 Hannes Reinecke
2010-06-01 9:24 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2010-06-01 9:19 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
When using SCSI reservations a 'reservation conflict' error
is actually expected. So we should better use the normal
SCSI_LOG_XXX functions to make it configurable for those
cases where we're actually interested in the error.
Signed-off-by: Hannes Reinecke <hare@suse.de>
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index a5d630f..def540d 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1509,8 +1509,8 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
return SUCCESS;
case RESERVATION_CONFLICT:
- sdev_printk(KERN_INFO, scmd->device,
- "reservation conflict\n");
+ SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, scmd->device,
+ "reservation conflict\n"));
return SUCCESS; /* causes immediate i/o error */
default:
return FAILED;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi_error: blank out reservation conflict printk
2010-06-01 9:19 [PATCH] scsi_error: blank out reservation conflict printk Hannes Reinecke
@ 2010-06-01 9:24 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2010-06-01 9:24 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: James Bottomley, linux-scsi
On Tue, 2010-06-01 at 11:19 +0200, Hannes Reinecke wrote:
> When using SCSI reservations a 'reservation conflict' error
> is actually expected. So we should better use the normal
> SCSI_LOG_XXX functions to make it configurable for those
> cases where we're actually interested in the error.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index a5d630f..def540d 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -1509,8 +1509,8 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
> return SUCCESS;
>
> case RESERVATION_CONFLICT:
> - sdev_printk(KERN_INFO, scmd->device,
> - "reservation conflict\n");
> + SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, scmd->device,
> + "reservation conflict\n"));
> return SUCCESS; /* causes immediate i/o error */
> default:
> return FAILED;
Makes perfect sense to me.
:-)
Acked-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-01 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-01 9:19 [PATCH] scsi_error: blank out reservation conflict printk Hannes Reinecke
2010-06-01 9:24 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).