public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Justin P. Mattock"
	<justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used
Date: Tue, 15 Jun 2010 22:33:52 -0700	[thread overview]
Message-ID: <1276666434-11227-4-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1276666434-11227-1-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

The patch below fixes the warning message I am seeing with gcc 4.6.0
  CC      drivers/pci/bus.o
drivers/pci/bus.c: In function 'pci_enable_bridges':
drivers/pci/bus.c:237:6: warning: variable 'retval' set but not used

 Signed-off-by: Justin P. Mattock <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

---
 drivers/pci/bus.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 628ea20..84bdb48 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus)
 void pci_enable_bridges(struct pci_bus *bus)
 {
 	struct pci_dev *dev;
-	int retval;
 
 	list_for_each_entry(dev, &bus->devices, bus_list) {
 		if (dev->subordinate) {
 			if (!pci_is_enabled(dev)) {
-				retval = pci_enable_device(dev);
 				pci_set_master(dev);
 			}
 			pci_enable_bridges(dev->subordinate);
-- 
1.7.1.rc1.21.gf3bd6

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-06-16  5:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16  5:33 [PATCH 0/5] Fix set but unused variable warnings Justin P. Mattock
2010-06-16  5:33 ` [PATCH 1/5]wireless:hostap_main.c warning: variable 'iface' set but not used Justin P. Mattock
2010-06-16  5:33 ` [PATCH 2/5]wireless:hostap_ap.c Fix warning: variable 'fc' " Justin P. Mattock
     [not found] ` <1276666434-11227-1-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-16  5:33   ` Justin P. Mattock [this message]
2010-06-16  5:42     ` [PATCH 3/5]pci:bus.c Fix variable 'retval' " Julian Calaby
2010-06-16  6:56       ` Justin P. Mattock
2010-06-16  6:07     ` Junchang Wang
2010-06-16  6:58       ` Justin P. Mattock
     [not found]       ` <20100616060738.GA12461-XdzxFlWC3YoNXa20cRcSYJWwCtiK4VeF@public.gmane.org>
2010-06-16 17:01         ` Justin P. Mattock
2010-06-17 17:15       ` Justin P. Mattock
2010-06-16  5:33 ` [PATCH 4/5]pci:setup_bus.c Fix warning: " Justin P. Mattock
2010-06-18 17:23   ` Jesse Barnes
2010-06-18 17:31     ` Justin P. Mattock
2010-06-18 18:38     ` Justin P. Mattock
2010-06-18 18:48     ` Yinghai Lu
2010-06-18 19:49       ` Jesse Barnes
2010-06-18 19:59         ` Justin P. Mattock
     [not found]           ` <4C1BD024.1030707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-18 20:05             ` Jesse Barnes
2010-06-18 20:26               ` Justin P. Mattock
2010-06-18 20:46                 ` Jesse Barnes
     [not found]                   ` <20100618134622.7db9f913-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2010-06-18 21:12                     ` Justin P. Mattock
2010-06-16  5:33 ` [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' " Justin P. Mattock
2010-06-16 11:05   ` Matthew Wilcox
2010-06-16 15:34   ` James Bottomley
2010-06-16 16:00     ` Justin P. Mattock
2010-06-16 17:25       ` Rolf Eike Beer
2010-06-16 17:33       ` James Bottomley
2010-06-16 18:14         ` Justin P. Mattock
     [not found]         ` <1276709590.2847.176.camel-0iu6Cu4xQGLYCGPCin2YbQ@public.gmane.org>
2010-06-17 16:16           ` Justin P. Mattock
2010-06-18 19:37             ` James Bottomley
2010-06-18 19:55               ` Justin P. Mattock
2010-06-18 20:17               ` Justin P. Mattock
2010-06-16  5:52 ` [PATCH 0/5] Fix set but unused variable warnings Julian Calaby
2010-06-16  7:01   ` Justin P. Mattock
2010-06-16 11:09   ` Matthew Wilcox
2010-06-16 11:30     ` Julian Calaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276666434-11227-4-git-send-email-justinmattock@gmail.com \
    --to=justinmattock-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox