Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: "Yang, Bo" <Bo.Yang@lsi.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
	"'akpm@osdl.org'" <akpm@osdl.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset (OCR): Add and initialize the OCR relaed variable
Date: Thu, 17 Jun 2010 11:19:30 -0500	[thread overview]
Message-ID: <1276791570.7398.12.camel@mulgrave.site> (raw)
In-Reply-To: <4B6A08C587958942AA3002690DD4F8C3D0804554@cosmail02.lsi.com>

On Wed, 2010-06-09 at 21:54 -0600, Yang, Bo wrote:
> To support online controller reset, driver need to define some
> instance based variable and initialize them.

This doesn't compile:

  CC [M]  drivers/scsi/megaraid/megaraid_sas.o
drivers/scsi/megaraid/megaraid_sas.c: In function
‘megasas_deplete_reply_queue’:
drivers/scsi/megaraid/megaraid_sas.c:2090: warning: unused variable
‘fw_state’
drivers/scsi/megaraid/megaraid_sas.c: In function ‘megasas_init_mfi’:
drivers/scsi/megaraid/megaraid_sas.c:3023: error: ‘struct
megasas_ctrl_prop’ has no member named ‘OnOffProperties’
drivers/scsi/megaraid/megaraid_sas.c: In function ‘megasas_probe_one’:
drivers/scsi/megaraid/megaraid_sas.c:3486: error:
‘process_fw_state_change_wq’ undeclared (first use in this function)
drivers/scsi/megaraid/megaraid_sas.c:3486: error: (Each undeclared
identifier is reported only once
drivers/scsi/megaraid/megaraid_sas.c:3486: error: for each function it
appears in.)

Because OnOffProperties structure is defined in patch 6/12 as is the
process_fw_state_change_wq function.

I've got 1-4 ... please resubmit 5-12 so they actually build in the
order submitted.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-06-17 16:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-10  3:54 [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset (OCR): Add and initialize the OCR relaed variable Yang, Bo
2010-06-17 16:19 ` James Bottomley [this message]
2010-06-17 17:00   ` Yang, Bo
2010-06-18 20:49 ` Yang, Bo
2010-08-05 20:18   ` Yang, Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276791570.7398.12.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=Bo.Yang@lsi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox