public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James.Bottomley@suse.de, "Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used
Date: Fri, 18 Jun 2010 13:16:07 -0700	[thread overview]
Message-ID: <1276892167-24161-1-git-send-email-justinmattock@gmail.com> (raw)

The below patch fixes a warning message generated by gcc 4.6.0
  CC      drivers/scsi/hosts.o
drivers/scsi/hosts.c: In function 'scsi_host_alloc':
drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used
 Signed-off-by: James Bottomley <James.Bottomley@suse.de>
 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/scsi/hosts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 6660fa9..4cc99b7 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
 {
 	struct Scsi_Host *shost;
 	gfp_t gfp_mask = GFP_KERNEL;
-	int rval;
 
 	if (sht->unchecked_isa_dma && privsize)
 		gfp_mask |= __GFP_DMA;
@@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
 	shost->ehandler = kthread_run(scsi_error_handler, shost,
 			"scsi_eh_%d", shost->host_no);
 	if (IS_ERR(shost->ehandler)) {
-		rval = PTR_ERR(shost->ehandler);
+		printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n", 
+			shost->host_no, PTR_ERR(shost->ehandler));
 		goto fail_kfree;
 	}
 
-- 
1.7.1.rc1.21.gf3bd6


             reply	other threads:[~2010-06-18 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 20:16 Justin P. Mattock [this message]
2010-06-18 20:28 ` [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used James Bottomley
2010-06-18 20:38   ` Justin P. Mattock
2010-06-18 20:47 ` Matthew Wilcox
2010-06-18 21:24   ` Justin P. Mattock
2010-06-19 19:32   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276892167-24161-1-git-send-email-justinmattock@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=James.Bottomley@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox