Re: [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used

[James Bottomley <James.Bottomley@suse.de>]

On Fri, 2010-06-18 at 14:47 -0600, Matthew Wilcox wrote:
> On Fri, Jun 18, 2010 at 01:16:07PM -0700, Justin P. Mattock wrote:
> > @@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
> >  	shost->ehandler = kthread_run(scsi_error_handler, shost,
> >  			"scsi_eh_%d", shost->host_no);
> >  	if (IS_ERR(shost->ehandler)) {
> > -		rval = PTR_ERR(shost->ehandler);
> > +		printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n", 
> > +			shost->host_no, PTR_ERR(shost->ehandler));
> 
> Surely this should simply be:
> 
> 		shost_printk(KERN_WARNING, shost, "error handler thread failed"
> 				"to spawn (%ld)\n", PTR_ERR(shost->ehandler));

Actually, I'm wary of doing this: the device isn't fully initialised
(it's unparented and not added to the system) so that could cause
problems down the road for intelligent error gathering.  It's why we
tend to do the printk scsi%d (or dev_printk on the parent) thing up
until scsi_host_add().

James