[PATCH 2/2] scsi: fix kconfig dependency warnings

[PATCH 2/2] scsi: fix kconfig dependency warnings

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix kconfig dependency warnings in scsi/Kconfig:

warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Ralf Baechle <ralf@linux-mips.org>
---
 drivers/scsi/Kconfig        |    3 ++-
 drivers/scsi/libsas/Kconfig |    1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

--- linux-next-20100810.orig/drivers/scsi/libsas/Kconfig
+++ linux-next-20100810/drivers/scsi/libsas/Kconfig
@@ -26,6 +26,7 @@ config SCSI_SAS_LIBSAS
 	tristate "SAS Domain Transport Attributes"
 	depends on SCSI
 	select SCSI_SAS_ATTRS
+	select BLK_DEV_BSG
 	help
 	  This provides transport specific helpers for SAS drivers which
 	  use the domain device construct (like the aic94xxx).
--- linux-next-20100810.orig/drivers/scsi/Kconfig
+++ linux-next-20100810/drivers/scsi/Kconfig
@@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
 
 config SCSI_SAS_ATTRS
 	tristate "SAS Transport Attributes"
-	depends on SCSI && BLK_DEV_BSG
+	depends on SCSI
+	select BLK_DEV_BSG
 	help
 	  If you wish to export transport-specific information about
 	  each attached SAS device to sysfs, say Y.

Re: [PATCH 2/2] scsi: fix kconfig dependency warnings

[James Bottomley]

On Tue, 2010-08-17 at 11:36 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kconfig dependency warnings in scsi/Kconfig:
> 
> warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Ralf Baechle <ralf@linux-mips.org>
> ---
>  drivers/scsi/Kconfig        |    3 ++-
>  drivers/scsi/libsas/Kconfig |    1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100810.orig/drivers/scsi/libsas/Kconfig
> +++ linux-next-20100810/drivers/scsi/libsas/Kconfig
> @@ -26,6 +26,7 @@ config SCSI_SAS_LIBSAS
>  	tristate "SAS Domain Transport Attributes"
>  	depends on SCSI
>  	select SCSI_SAS_ATTRS
> +	select BLK_DEV_BSG

This isn't right if you do the below.

Selects cascade.

>  	help
>  	  This provides transport specific helpers for SAS drivers which
>  	  use the domain device construct (like the aic94xxx).
> --- linux-next-20100810.orig/drivers/scsi/Kconfig
> +++ linux-next-20100810/drivers/scsi/Kconfig
> @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
>  
>  config SCSI_SAS_ATTRS
>  	tristate "SAS Transport Attributes"
> -	depends on SCSI && BLK_DEV_BSG
> +	depends on SCSI
> +	select BLK_DEV_BSG

So this is the only part that's necessary, isn't it?  Could you resubmit
with just this?

Thanks,

James

[PATCH 2/2 v2] scsi: fix kconfig dependency warnings

[Randy Dunlap]

Thanks for your comments.


From: Randy Dunlap <randy.dunlap@oracle.com>

Fix kconfig dependency warnings in scsi/Kconfig:

warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Ralf Baechle <ralf@linux-mips.org>
---
 drivers/scsi/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20100817.orig/drivers/scsi/Kconfig
+++ linux-next-20100817/drivers/scsi/Kconfig
@@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
 
 config SCSI_SAS_ATTRS
 	tristate "SAS Transport Attributes"
-	depends on SCSI && BLK_DEV_BSG
+	depends on SCSI
+	select BLK_DEV_BSG
 	help
 	  If you wish to export transport-specific information about
 	  each attached SAS device to sysfs, say Y.