* [PATCH] tcm/pscsi: Convert struct bio->bi_rw assignment to use REQ_WRITE
@ 2010-08-30 0:26 Nicholas A. Bellinger
0 siblings, 0 replies; only message in thread
From: Nicholas A. Bellinger @ 2010-08-30 0:26 UTC (permalink / raw)
To: linux-scsi, linux-kernel; +Cc: Christoph Hellwig, Tejun Heo, Nicholas Bellinger
From: Nicholas Bellinger <nab@linux-iscsi.org>
Greetings hch and tejun,
This patch updates pscsi_map_task_SG() to use the new .36-rc REQ_WRITE
macro in include/linux/blk_types.h when setting struct bio->bi_rw for
WRITE I/O. This replaces the legacy (1 << BIO_RW) assignment, for which
the new REQ_WRITE macro expands to:
#define REQ_WRITE (1 << __REQ_WRITE)
to match the old BIO_RW assignement.
Thanks!
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
drivers/target/target_core_pscsi.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 517268d..64808f1 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -30,6 +30,7 @@
#include <linux/string.h>
#include <linux/timer.h>
#include <linux/blkdev.h>
+#include <linux/blk_types.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/smp_lock.h>
@@ -1103,11 +1104,9 @@ static int pscsi_map_task_SG(struct se_task *task)
bio = pscsi_get_bio(pdv, nr_vecs);
if (!(bio))
goto fail;
- /*
- * FIXME: Use bio_set_dir() when avaliable
- */
+
if (rw)
- bio->bi_rw |= (1 << BIO_RW);
+ bio->bi_rw |= REQ_WRITE;
DEBUG_PSCSI("PSCSI: Allocated bio: %p,"
" dir: %s nr_vecs: %d\n", bio,
--
1.5.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-30 0:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 0:26 [PATCH] tcm/pscsi: Convert struct bio->bi_rw assignment to use REQ_WRITE Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).