* [PATCH 7/8] tcm_loop: Remove host_lock unlock() + lock() from tcm_loop_queuecommand()
@ 2010-09-16 22:36 Nicholas A. Bellinger
0 siblings, 0 replies; only message in thread
From: Nicholas A. Bellinger @ 2010-09-16 22:36 UTC (permalink / raw)
To: linux-scsi, linux-kernel, Vasu Dev, Tim Chen, Andi Kleen
Cc: James Smart, Andrew Vasquez, FUJITA Tomonori, Hannes Reinecke,
Joe Eykholt, Christoph Hellwig, Nicholas Bellinger
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch removes the now legacy host_lock unlock() + lock() optimization
from tcm_loop_fabric_scsi.c:tcm_loop_queuecommand()
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
drivers/target/tcm_loop/tcm_loop_fabric_scsi.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/target/tcm_loop/tcm_loop_fabric_scsi.c b/drivers/target/tcm_loop/tcm_loop_fabric_scsi.c
index b95ed03..a0a1a55 100644
--- a/drivers/target/tcm_loop/tcm_loop_fabric_scsi.c
+++ b/drivers/target/tcm_loop/tcm_loop_fabric_scsi.c
@@ -324,8 +324,6 @@ static int tcm_loop_queuecommand(
" scsi_buf_len: %u\n", sc->device->host->host_no,
sc->device->id, sc->device->channel, sc->device->lun,
sc->cmnd[0], scsi_bufflen(sc));
-
- spin_unlock_irq(host->host_lock);
/*
* Locate the tcm_loop_hba_t pointer
*/
@@ -345,7 +343,6 @@ static int tcm_loop_queuecommand(
*/
se_cmd = tcm_loop_allocate_core_cmd(tl_hba, se_tpg, sc);
if (!(se_cmd)) {
- spin_lock_irq(host->host_lock);
sc->result = host_byte(DID_ERROR);
(*done)(sc);
return 0;
@@ -354,10 +351,6 @@ static int tcm_loop_queuecommand(
* Queue up the newly allocated to be processed in TCM thread context.
*/
se_cmd->transport_add_cmd_to_queue(se_cmd, TRANSPORT_NEW_CMD_MAP);
- /*
- * Reaquire the the struct scsi_host->host_lock before returning
- */
- spin_lock_irq(host->host_lock);
return 0;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-09-16 22:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-16 22:36 [PATCH 7/8] tcm_loop: Remove host_lock unlock() + lock() from tcm_loop_queuecommand() Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).