* [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active
@ 2010-09-21 19:17 David Milburn
2010-09-21 19:41 ` Jeff Garzik
2010-09-21 20:51 ` James Bottomley
0 siblings, 2 replies; 4+ messages in thread
From: David Milburn @ 2010-09-21 19:17 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, jeff, k.skarlatos
Non-NCQ commands should run exclusively, ata_qc_issue warns when mixing
non-NCQ and NCQ commands.
Signed-off-by: David Milburn <dmilburn@redhat.com>
Reported-by: Konstantinos Skarlatos <k.skarlatos@gmail.com>
---
drivers/scsi/libsas/sas_ata.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 042153c..ddbade7 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -347,6 +347,7 @@ static int sas_ata_scr_read(struct ata_link *link, unsigned int sc_reg_in,
static struct ata_port_operations sas_sata_ops = {
.phy_reset = sas_ata_phy_reset,
.post_internal_cmd = sas_ata_post_internal,
+ .qc_defer = ata_std_qc_defer,
.qc_prep = ata_noop_qc_prep,
.qc_issue = sas_ata_qc_issue,
.qc_fill_rtf = sas_ata_qc_fill_rtf,
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active
2010-09-21 19:17 [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active David Milburn
@ 2010-09-21 19:41 ` Jeff Garzik
2010-09-21 20:51 ` James Bottomley
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2010-09-21 19:41 UTC (permalink / raw)
To: David Milburn; +Cc: linux-scsi, James.Bottomley, k.skarlatos
On Tue, Sep 21, 2010 at 3:17 PM, David Milburn <dmilburn@redhat.com> wrote:
> Non-NCQ commands should run exclusively, ata_qc_issue warns when mixing
> non-NCQ and NCQ commands.
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> Reported-by: Konstantinos Skarlatos <k.skarlatos@gmail.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active
2010-09-21 19:17 [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active David Milburn
2010-09-21 19:41 ` Jeff Garzik
@ 2010-09-21 20:51 ` James Bottomley
2010-09-22 0:24 ` David Milburn
1 sibling, 1 reply; 4+ messages in thread
From: James Bottomley @ 2010-09-21 20:51 UTC (permalink / raw)
To: David Milburn; +Cc: linux-scsi, jeff, k.skarlatos
On Tue, 2010-09-21 at 14:17 -0500, David Milburn wrote:
> Non-NCQ commands should run exclusively, ata_qc_issue warns when mixing
> non-NCQ and NCQ commands.
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> Reported-by: Konstantinos Skarlatos <k.skarlatos@gmail.com>
> ---
> drivers/scsi/libsas/sas_ata.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 042153c..ddbade7 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -347,6 +347,7 @@ static int sas_ata_scr_read(struct ata_link *link, unsigned int sc_reg_in,
> static struct ata_port_operations sas_sata_ops = {
> .phy_reset = sas_ata_phy_reset,
> .post_internal_cmd = sas_ata_post_internal,
> + .qc_defer = ata_std_qc_defer,
What does this do on the card that doesn't need it: the aic94xx? That
one takes in a pipeline of commands and takes responsibility for getting
the issue right. Something like this throttles the pipeline higher than
the aic94xx is expecting. However, as long as it's not too much of a
performance problem, I don't mind applying it.
James
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active
2010-09-21 20:51 ` James Bottomley
@ 2010-09-22 0:24 ` David Milburn
0 siblings, 0 replies; 4+ messages in thread
From: David Milburn @ 2010-09-22 0:24 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, jeff, k.skarlatos
James Bottomley wrote:
> On Tue, 2010-09-21 at 14:17 -0500, David Milburn wrote:
>> Non-NCQ commands should run exclusively, ata_qc_issue warns when mixing
>> non-NCQ and NCQ commands.
>>
>> Signed-off-by: David Milburn <dmilburn@redhat.com>
>> Reported-by: Konstantinos Skarlatos <k.skarlatos@gmail.com>
>> ---
>> drivers/scsi/libsas/sas_ata.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
>> index 042153c..ddbade7 100644
>> --- a/drivers/scsi/libsas/sas_ata.c
>> +++ b/drivers/scsi/libsas/sas_ata.c
>> @@ -347,6 +347,7 @@ static int sas_ata_scr_read(struct ata_link *link, unsigned int sc_reg_in,
>> static struct ata_port_operations sas_sata_ops = {
>> .phy_reset = sas_ata_phy_reset,
>> .post_internal_cmd = sas_ata_post_internal,
>> + .qc_defer = ata_std_qc_defer,
>
> What does this do on the card that doesn't need it: the aic94xx? That
> one takes in a pipeline of commands and takes responsibility for getting
> the issue right. Something like this throttles the pipeline higher than
> the aic94xx is expecting. However, as long as it's not too much of a
> performance problem, I don't mind applying it.
James,
For any driver using sas_sata_ops, it could effect performance for
those drivers whose execute_task handles both, though I can't say
I am real familiar with aic94xx.
Thanks,
David
>
> James
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-22 0:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-21 19:17 [PATCH] mvsas: defer non-NCQ cmds when NCQ cmds are active David Milburn
2010-09-21 19:41 ` Jeff Garzik
2010-09-21 20:51 ` James Bottomley
2010-09-22 0:24 ` David Milburn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).