From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [RFC v3 10/15] buslogic: Remove host_lock unlock() + lock() from BusLogic_QueueCommand() Date: Thu, 23 Sep 2010 16:38:54 -0700 Message-ID: <1285285134-16531-1-git-send-email-nab@linux-iscsi.org> Return-path: Received: from smtp125.sbc.mail.sp1.yahoo.com ([69.147.65.184]:28814 "HELO smtp125.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756656Ab0IWXi5 (ORCPT ); Thu, 23 Sep 2010 19:38:57 -0400 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , MPTFusionLinux , "eata.c maintainer" , Nicholas Bellinger From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization from buslogic.c:BusLogic_QueueCommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/BusLogic.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c index fc0b4b8..f39b4fc 100644 --- a/drivers/scsi/BusLogic.c +++ b/drivers/scsi/BusLogic.c @@ -2837,9 +2837,7 @@ static int BusLogic_QueueCommand(struct scsi_cmnd *Command, void (*CompletionRou */ CCB = BusLogic_AllocateCCB(HostAdapter); if (CCB == NULL) { - spin_unlock_irq(HostAdapter->SCSI_Host->host_lock); BusLogic_Delay(1); - spin_lock_irq(HostAdapter->SCSI_Host->host_lock); CCB = BusLogic_AllocateCCB(HostAdapter); if (CCB == NULL) { Command->result = DID_ERROR << 16; @@ -2965,10 +2963,8 @@ static int BusLogic_QueueCommand(struct scsi_cmnd *Command, void (*CompletionRou error as a Host Adapter Hard Reset should be initiated soon. */ if (!BusLogic_WriteOutgoingMailbox(HostAdapter, BusLogic_MailboxStartCommand, CCB)) { - spin_unlock_irq(HostAdapter->SCSI_Host->host_lock); BusLogic_Warning("Unable to write Outgoing Mailbox - " "Pausing for 1 second\n", HostAdapter); BusLogic_Delay(1); - spin_lock_irq(HostAdapter->SCSI_Host->host_lock); if (!BusLogic_WriteOutgoingMailbox(HostAdapter, BusLogic_MailboxStartCommand, CCB)) { BusLogic_Warning("Still unable to write Outgoing Mailbox - " "Host Adapter Dead?\n", HostAdapter); BusLogic_DeallocateCCB(CCB); -- 1.7.3