From: James Bottomley <James.Bottomley@suse.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: James Smart <james.smart@emulex.com>,
linux-scsi@vger.kernel.org, Mike Christie <michaelc@cs.wisc.edu>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH] SCSI: remove noop in fc_bsg_goose_queue()
Date: Mon, 27 Sep 2010 07:58:33 +0900 [thread overview]
Message-ID: <1285541913.2888.71.camel@mulgrave.site> (raw)
In-Reply-To: <AANLkTi=mcETa6FfUCE9=J2_m1dS31UTBCdu5i76CAd+F@mail.gmail.com>
On Thu, 2010-09-23 at 23:10 +0800, Hillf Danton wrote:
> On Tue, Sep 21, 2010 at 11:41 PM, James Bottomley
> <James.Bottomley@suse.de> wrote:
> >
> > this code doesn't do anything because there's a bug in it. If you can
> > work out what it's trying to do, you should be able to fix the bug.
> >
> > James
> >
> What is it, James? Because I could not goto deep sleep with this bug in ear.
Think about it ... it's clearly something to do with the flag ... what
is it? Google is useful as well as looking in the block source code.
The key would be knowing what the flag does.
James
next prev parent reply other threads:[~2010-09-26 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 15:19 [PATCH] SCSI: remove noop in fc_bsg_goose_queue() Hillf Danton
2010-09-21 15:41 ` James Bottomley
2010-09-21 17:35 ` Hillf Danton
2010-09-23 15:10 ` Hillf Danton
2010-09-26 22:58 ` James Bottomley [this message]
2010-10-01 2:30 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285541913.2888.71.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=dhillf@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox