From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [RFC v4 03/19] libsas: Remove host_lock unlock() + lock() from sas_queuecommand() Date: Mon, 27 Sep 2010 19:05:31 -0700 Message-ID: <1285639531-7264-1-git-send-email-nab@linux-iscsi.org> Return-path: Received: from smtp101.sbc.mail.re3.yahoo.com ([66.196.96.84]:33547 "HELO smtp101.sbc.mail.re3.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933227Ab0I1CFh (ORCPT ); Mon, 27 Sep 2010 22:05:37 -0400 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , Jon Hawley , MPTFusionLinux , "eata.c maintainer" , Luben Tuikov , mvsas maintainer , pm8001 maintainer Jack Wang , Nicholas Bellinger From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization from sas_scsi_host.c:sas_queuecommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/libsas/sas_scsi_host.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index f0cfba9..bc1c97c 100644 --- a/drivers/scsi/libsas/sas_scsi_host.c +++ b/drivers/scsi/libsas/sas_scsi_host.c @@ -202,18 +202,14 @@ int sas_queue_up(struct sas_task *task) */ int sas_queuecommand(struct scsi_cmnd *cmd, void (*scsi_done)(struct scsi_cmnd *)) - __releases(host->host_lock) __acquires(dev->sata_dev.ap->lock) __releases(dev->sata_dev.ap->lock) - __acquires(host->host_lock) { int res = 0; struct domain_device *dev = cmd_to_domain_dev(cmd); struct Scsi_Host *host = cmd->device->host; struct sas_internal *i = to_sas_internal(host->transportt); - spin_unlock_irq(host->host_lock); - { struct sas_ha_struct *sas_ha = dev->port->ha; struct sas_task *task; @@ -254,7 +250,6 @@ int sas_queuecommand(struct scsi_cmnd *cmd, } } out: - spin_lock_irq(host->host_lock); return res; } -- 1.7.3