From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [RFC v4 19/19] u14-34f: Add scsi_cmd_get_serial() call Date: Mon, 27 Sep 2010 19:08:21 -0700 Message-ID: <1285639701-7585-1-git-send-email-nab@linux-iscsi.org> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , Jon Hawley , MPTFusionLinux , "eata.c maintainer" , Luben Tuikov , mvsas maintainer , pm8001 maintainer Jack Wang , Nicholas Bellinger List-Id: linux-scsi@vger.kernel.org From: Nicholas Bellinger This patch adds a scsi_cmd_get_serial() call in u14_34f_queuecommand() to setup a valid struct scsi_cmnd->serial_number because reorder() still depends upon this being set. Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/u14-34f.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c index 5d9fdee..ea20906 100644 --- a/drivers/scsi/u14-34f.c +++ b/drivers/scsi/u14-34f.c @@ -1255,6 +1255,12 @@ static int u14_34f_queuecommand(struct scsi_cmnd *SCpnt, void (*done)(struct scs /* j is the board number */ j = ((struct hostdata *) SCpnt->device->host->hostdata)->board_number; + /* + * Call scsi_cmd_get_serial() because we need a valid serial number + * for reorder(). + */ + scsi_cmd_get_serial(SCpnt); + if (SCpnt->host_scribble) panic("%s: qcomm, pid %ld, SCpnt %p already active.\n", BN(j), SCpnt->serial_number, SCpnt); -- 1.7.3