From: Matthew Wilcox <willy@linux.intel.com>
To: greg@kroah.com, linux-usb@vger.kernel.org,
linux-scsi@vger.kernel.org, sarah.a.sharp@linux.intel.com
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Matthew Wilcox <willy@linux.intel.com>
Subject: [PATCH 1/2] Move USB Storage definitions to their own header file
Date: Tue, 28 Sep 2010 06:14:55 -0400 [thread overview]
Message-ID: <1285668896-6356-1-git-send-email-willy@linux.intel.com> (raw)
From: Matthew Wilcox <matthew.r.wilcox@intel.com>
The libusual header file is hard to use from code that isn't part
of libusual. As the comment suggests, these definitions are moved to
their own header file, paralleling other USB classes.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
include/linux/usb/storage.h | 44 +++++++++++++++++++++++++++++++++++++++++++
include/linux/usb_usual.h | 37 +-----------------------------------
2 files changed, 45 insertions(+), 36 deletions(-)
create mode 100644 include/linux/usb/storage.h
diff --git a/include/linux/usb/storage.h b/include/linux/usb/storage.h
new file mode 100644
index 0000000..218caf0
--- /dev/null
+++ b/include/linux/usb/storage.h
@@ -0,0 +1,44 @@
+/*
+ * linux/usb/storage.h
+ *
+ * Copyright Matthew Wilcox for Intel Corp, 2010
+ *
+ * This file contains definitions taken from the
+ * USB Mass Storage Class Specification Overview
+ *
+ * Distributed under the terms of the GNU GPL, version two.
+ */
+
+/* Storage subclass codes */
+
+#define US_SC_RBC 0x01 /* Typically, flash devices */
+#define US_SC_8020 0x02 /* CD-ROM */
+#define US_SC_QIC 0x03 /* QIC-157 Tapes */
+#define US_SC_UFI 0x04 /* Floppy */
+#define US_SC_8070 0x05 /* Removable media */
+#define US_SC_SCSI 0x06 /* Transparent */
+#define US_SC_LOCKABLE 0x07 /* Password-protected */
+
+#define US_SC_ISD200 0xf0 /* ISD200 ATA */
+#define US_SC_CYP_ATACB 0xf1 /* Cypress ATACB */
+#define US_SC_DEVICE 0xff /* Use device's value */
+
+/* Storage protocol codes */
+
+#define US_PR_CBI 0x00 /* Control/Bulk/Interrupt */
+#define US_PR_CB 0x01 /* Control/Bulk w/o interrupt */
+#define US_PR_BULK 0x50 /* bulk only */
+#define US_PR_UAS 0x62 /* USB Attached SCSI */
+
+#define US_PR_USBAT 0x80 /* SCM-ATAPI bridge */
+#define US_PR_EUSB_SDDR09 0x81 /* SCM-SCSI bridge for SDDR-09 */
+#define US_PR_SDDR55 0x82 /* SDDR-55 (made up) */
+#define US_PR_DPCM_USB 0xf0 /* Combination CB/SDDR09 */
+#define US_PR_FREECOM 0xf1 /* Freecom */
+#define US_PR_DATAFAB 0xf2 /* Datafab chipsets */
+#define US_PR_JUMPSHOT 0xf3 /* Lexar Jumpshot */
+#define US_PR_ALAUDA 0xf4 /* Alauda chipsets */
+#define US_PR_KARMA 0xf5 /* Rio Karma */
+
+#define US_PR_DEVICE 0xff /* Use device's value */
+
diff --git a/include/linux/usb_usual.h b/include/linux/usb_usual.h
index a4b947e..f091dc6 100644
--- a/include/linux/usb_usual.h
+++ b/include/linux/usb_usual.h
@@ -74,42 +74,7 @@ enum { US_DO_ALL_FLAGS };
#define USB_US_TYPE(flags) (((flags) >> 24) & 0xFF)
#define USB_US_ORIG_FLAGS(flags) ((flags) & 0x00FFFFFF)
-/*
- * This is probably not the best place to keep these constants, conceptually.
- * But it's the only header included into all places which need them.
- */
-
-/* Sub Classes */
-
-#define US_SC_RBC 0x01 /* Typically, flash devices */
-#define US_SC_8020 0x02 /* CD-ROM */
-#define US_SC_QIC 0x03 /* QIC-157 Tapes */
-#define US_SC_UFI 0x04 /* Floppy */
-#define US_SC_8070 0x05 /* Removable media */
-#define US_SC_SCSI 0x06 /* Transparent */
-#define US_SC_LOCKABLE 0x07 /* Password-protected */
-
-#define US_SC_ISD200 0xf0 /* ISD200 ATA */
-#define US_SC_CYP_ATACB 0xf1 /* Cypress ATACB */
-#define US_SC_DEVICE 0xff /* Use device's value */
-
-/* Protocols */
-
-#define US_PR_CBI 0x00 /* Control/Bulk/Interrupt */
-#define US_PR_CB 0x01 /* Control/Bulk w/o interrupt */
-#define US_PR_BULK 0x50 /* bulk only */
-
-#define US_PR_USBAT 0x80 /* SCM-ATAPI bridge */
-#define US_PR_EUSB_SDDR09 0x81 /* SCM-SCSI bridge for SDDR-09 */
-#define US_PR_SDDR55 0x82 /* SDDR-55 (made up) */
-#define US_PR_DPCM_USB 0xf0 /* Combination CB/SDDR09 */
-#define US_PR_FREECOM 0xf1 /* Freecom */
-#define US_PR_DATAFAB 0xf2 /* Datafab chipsets */
-#define US_PR_JUMPSHOT 0xf3 /* Lexar Jumpshot */
-#define US_PR_ALAUDA 0xf4 /* Alauda chipsets */
-#define US_PR_KARMA 0xf5 /* Rio Karma */
-
-#define US_PR_DEVICE 0xff /* Use device's value */
+#include <linux/usb/storage.h>
/*
*/
--
1.7.1
next reply other threads:[~2010-09-28 10:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:14 Matthew Wilcox [this message]
2010-09-28 10:14 ` [PATCH 2/2] Add UAS driver Matthew Wilcox
[not found] ` <1285668896-6356-2-git-send-email-willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 13:13 ` Oliver Neukum
2010-09-29 0:54 ` Matthew Wilcox
2010-09-29 4:47 ` Sarah Sharp
[not found] ` <20100929005413.GB4689-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-29 20:20 ` Oliver Neukum
2010-09-30 6:04 ` Rolf Eike Beer
2010-09-28 13:41 ` David Vrabel
2010-09-29 0:55 ` Matthew Wilcox
2010-09-29 3:30 ` David Brownell
2010-09-28 17:51 ` Matthew Dharm
2010-09-28 18:11 ` Greg KH
2010-09-28 18:52 ` Matthew Dharm
2010-09-29 1:56 ` Greg KH
[not found] ` <20100928175122.GE25677-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>
2010-09-29 1:01 ` Matthew Wilcox
2010-09-29 2:08 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285668896-6356-1-git-send-email-willy@linux.intel.com \
--to=willy@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).