* [PATCH] scsi: hpsa: fix information leak to userland
@ 2010-10-27 15:40 Vasiliy Kulikov
2010-10-27 15:47 ` Miller, Mike (OS Dev)
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-10-27 15:40 UTC (permalink / raw)
To: kernel-janitors
Cc: Stephen M. Cameron, James E.J. Bottomley, Mike Miller,
iss_storagedev, linux-scsi, linux-kernel
Structure IOCTL_Command_struct is copied to userland with
some padding fields at the end of the struct unitialized.
It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
drivers/scsi/hpsa.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index c5d0606..641a38c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -2298,6 +2298,7 @@ static int hpsa_ioctl32_passthru(struct scsi_device *dev, int cmd, void *arg)
int err;
u32 cp;
+ memset(&arg64, 0, sizeof(arg64));
err = 0;
err |= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
sizeof(arg64.LUN_info));
@@ -2334,6 +2335,7 @@ static int hpsa_ioctl32_big_passthru(struct scsi_device *dev,
int err;
u32 cp;
+ memset(&arg64, 0, sizeof(arg64));
err = 0;
err |= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
sizeof(arg64.LUN_info));
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] scsi: hpsa: fix information leak to userland
2010-10-27 15:40 [PATCH] scsi: hpsa: fix information leak to userland Vasiliy Kulikov
@ 2010-10-27 15:47 ` Miller, Mike (OS Dev)
0 siblings, 0 replies; 2+ messages in thread
From: Miller, Mike (OS Dev) @ 2010-10-27 15:47 UTC (permalink / raw)
To: Vasiliy Kulikov, kernel-janitors@vger.kernel.org
Cc: Stephen M. Cameron, James E.J. Bottomley, ISS StorageDev,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Vasiliy Kulikov [mailto:segooon@gmail.com]
> Sent: Wednesday, October 27, 2010 10:41 AM
> To: kernel-janitors@vger.kernel.org
> Cc: Stephen M. Cameron; James E.J. Bottomley; Miller, Mike (OS Dev);
> ISS StorageDev; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] scsi: hpsa: fix information leak to userland
>
> Structure IOCTL_Command_struct is copied to userland with
> some padding fields at the end of the struct unitialized.
> It leads to leaking of contents of kernel stack memory.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tested.
>
> drivers/scsi/hpsa.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index c5d0606..641a38c 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -2298,6 +2298,7 @@ static int hpsa_ioctl32_passthru(struct
> scsi_device *dev, int cmd, void *arg)
> int err;
> u32 cp;
>
> + memset(&arg64, 0, sizeof(arg64));
> err = 0;
> err |= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
> sizeof(arg64.LUN_info));
> @@ -2334,6 +2335,7 @@ static int hpsa_ioctl32_big_passthru(struct
> scsi_device *dev,
> int err;
> u32 cp;
>
> + memset(&arg64, 0, sizeof(arg64));
> err = 0;
> err |= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
> sizeof(arg64.LUN_info));
> --
> 1.7.0.4
Acked-by: Mike Milelr <mike.miller@hp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-27 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-27 15:40 [PATCH] scsi: hpsa: fix information leak to userland Vasiliy Kulikov
2010-10-27 15:47 ` Miller, Mike (OS Dev)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox