From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] target: Kconfig fixes
Date: Mon, 15 Nov 2010 12:31:07 -0800 [thread overview]
Message-ID: <1289853067.22107.111.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20101115122621.ea812a6c.randy.dunlap@oracle.com>
On Mon, 2010-11-15 at 12:26 -0800, Randy Dunlap wrote:
> On Mon, 15 Nov 2010 14:43:15 -0500 Christoph Hellwig wrote:
>
> > Use the menuconfig verb for the main TARGET_CORE option to make it look
> > better in menuconfig, use a big if TARGET_CORE to get rid of a lot of
> > depends, use help instead of ---help---, shorten lines to be under 80
> > chars where applicable, convert options to bool instead of tristate
> > where they should be, and remove the discuraged default values for
> > all the options.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Yes, mostly looks good, with the small exception of a few spaces-for-indents
> that should be tabs. (identified below)
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
Thanks guys, commited w/ Randy's spaces-for-indents fixes as d04f491.
--nab
prev parent reply other threads:[~2010-11-15 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 19:43 [PATCH 1/2] target: Kconfig fixes Christoph Hellwig
2010-11-15 20:26 ` Randy Dunlap
2010-11-15 20:31 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289853067.22107.111.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox