* [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static
@ 2010-11-27 21:37 Ben Hutchings
2010-11-30 7:06 ` Yang, Bo
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2010-11-27 21:37 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: Neela Syam Kolli, linux-scsi
There is no reason for this to be extern.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/scsi/megaraid/megaraid_sas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index 7451bc0..7050a88 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -115,7 +115,7 @@ static u32 megasas_dbg_lvl;
static u32 support_device_change;
/* define lock for aen poll */
-spinlock_t poll_aen_lock;
+static spinlock_t poll_aen_lock;
static void
megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
--
1.7.2.3
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static
2010-11-27 21:37 [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static Ben Hutchings
@ 2010-11-30 7:06 ` Yang, Bo
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Bo @ 2010-11-30 7:06 UTC (permalink / raw)
To: Ben Hutchings, James E.J. Bottomley
Cc: DL-MegaRAID Linux, linux-scsi@vger.kernel.org
Ben,
I also don't find out the negative for the original define.
Thanks,
Bo Yang
-----Original Message-----
From: Ben Hutchings [mailto:ben@decadent.org.uk]
Sent: Saturday, November 27, 2010 4:37 PM
To: James E.J. Bottomley
Cc: DL-MegaRAID Linux; linux-scsi@vger.kernel.org
Subject: [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static
There is no reason for this to be extern.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/scsi/megaraid/megaraid_sas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index 7451bc0..7050a88 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -115,7 +115,7 @@ static u32 megasas_dbg_lvl;
static u32 support_device_change;
/* define lock for aen poll */
-spinlock_t poll_aen_lock;
+static spinlock_t poll_aen_lock;
static void
megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
--
1.7.2.3
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-30 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-27 21:37 [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static Ben Hutchings
2010-11-30 7:06 ` Yang, Bo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox