linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: linux-scsi <linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
	Hannes Reinecke <hare@suse.de>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	James Bottomley <James.Bottomley@suse.de>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH 0/2] target: Updates for HW target mode
Date: Mon, 13 Dec 2010 15:58:41 -0800	[thread overview]
Message-ID: <1292284723-6806-1-git-send-email-nab@linux-iscsi.org> (raw)

From: Nicholas Bellinger <nab@linux-iscsi.org>

Greetings folks,

This short series fixes two issues found in target core code during recent
HW target mode module development and validation.  These two patches have been
merged into lio-core-2.6.git/lio-4.0 and master, and now allow generic HW target
mode to function using TCM code for the upcoming v4.0.0-rc6 release.

Patch #1 involves changing transport_generic_write_pending() to make sure
that transport_generic_handle_data() will never have to sleep waiting for
the struct target_core_fabric_ops->write_pending() callback to complete.

Patch #2 changes locking access to the struct se_nacl->nacl_sess_lock to
disable interrupts using spin_lock_irq(), and handles the special case for
target_core_pr.c: core_scsi3_pri_read_full_status() so that
transport_deregister_session_configfs() can be called directly from interrupt
context during HW target mode NEXUS -> TCM session shutdown and reset.

So far these have been tested using FC HW target mode via PCIe device-passthrough
from within KVM guest on .37-rc3 code.  This FC HW target module code will be
posted seperately to linux-scsi for review.

Thanks,

Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>

Nicholas Bellinger (2):
  target: Fix tfo->write_pending() fabric callback ordering
  target: Convert se_nacl->nacl_sess_lock to use spin_lock_irq()

 drivers/target/target_core_fabric_lib.c |    8 +++---
 drivers/target/target_core_pr.c         |   11 ++++++++
 drivers/target/target_core_transport.c  |   39 ++++++++++++++++---------------
 3 files changed, 35 insertions(+), 23 deletions(-)


             reply	other threads:[~2010-12-13 23:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13 23:58 Nicholas A. Bellinger [this message]
2010-12-13 23:58 ` [PATCH 1/2] target: Fix tfo->write_pending() fabric callback ordering Nicholas A. Bellinger
2010-12-13 23:58 ` [PATCH 2/2] target: Convert se_nacl->nacl_sess_lock to use spin_lock_irq() Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292284723-6806-1-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=James.Bottomley@suse.de \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).