Re: [PATCH 7/11]: megaraid_sas: Add MegaRAID 9265/9285 specific functions: megaraid_sas_fusion.c

[James Bottomley <James.Bottomley@suse.de>]

On Fri, 2010-12-17 at 11:42 +0100, Tomas Henzl wrote:
> On 12/16/2010 06:13 PM, adam radford wrote:
> > On Thu, Dec 16, 2010 at 8:58 AM, adam radford <aradford@gmail.com> wrote:
> >   
> >> On Thu, Dec 16, 2010 at 5:57 AM, Tomas Henzl <thenzl@redhat.com> wrote:
> >>     
> >>> Hi Adam, Bo,
> >>>
> >>> The function megasas_fusion_ocr_wq seems to be used already in patch 6/11
> >>> and declared in 7/11 - this breaks bisectability.
> >>>
> >>> Further my compiler complains about a large frame size.
> >>> Probably the 'struct scsi_device dev' is too large to be on stack.
> >>> make checkstack
> >>> ...
> >>> 0x000090f4 megasas_fusion_ocr_wq [megaraid_sas]:        1696
> >>>
> >>>       
> >> Tomas,
> >>
> >> Thanks, we will fix this and repost patches 6 thru 10.
> >>
> >> -Adam
> >>
> >>     
> > Tomas,
> >
> > Actually, if you look the patch 6, we put a note in there, that
> > patches 6 thru 10 must be applied 'at once' for the build to work:
> >
> > "Note: Patches 6 thru 10 have to be applied at once in order to build."
> >   
> I'm not sure if git-bisect can understand this.

He means I apply them all at once as a single commit.  We had to do this
with the first five patches of Online Controller Reset which were
likewise unbisectable.   It's a way of getting around the mailing list
patch size limite (currently about $150k, I think) and making the
patches more reviewable.

What I do want for this is a rolled up change log for the entire commit,
please.

James

> > This has been allowed on this list before.  Otherwise, we would have a
> > very large patch while turning on the new support for this controller,
> > making the patch less review-able by the community.
> >   
> If the maintainer accepts this, than I'm fine too. 
> 
> > I will look into and fix the large frame size compile issue you are
> > seeing and re-post the appropriate patches.
> >   
> Thanks.
> Tomas
> 
> > -Adam
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >   
>