From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: [PATCH 00/12] LLD host_lock-less conversion status for .38 Date: Thu, 23 Dec 2010 13:17:18 -0800 Message-ID: <1293139038.4649.117.camel@haakon2.linux-iscsi.org> References: <1292793727-31957-1-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linux-iscsi.org ([67.23.28.174]:53992 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608Ab0LWVXO (ORCPT ); Thu, 23 Dec 2010 16:23:14 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: adam radford Cc: linux-scsi , linux-kernel , James Bottomley , Jeff Garzik , Christoph Hellwig , FUJITA Tomonori , Hannes Reinecke , Mike Christie , Mike Anderson , Tejun Heo , Vasu Dev , Tim Chen , Andi Kleen , Douglas Gilbert , Kashyap Desai , MPTFusionLinux On Mon, 2010-12-20 at 11:33 -0800, adam radford wrote: > On Sun, Dec 19, 2010 at 1:21 PM, Nicholas A. Bellinger > wrote: > > *) megaraid_sas: Running in host_lock-less mode with MSI-X interrupts > > > > This has not been tested yet, but I would like to get some review from the LSI > > megaraid_sas folks now that their patches to enable MSI-X interrupts has been sent > > to linux-scsi. > > > > AdamR, any thoughts or comments to add here..? > > Nick, > > Your patch will not work with the new MegaRAID adapter support I have > sent in recently. It requires the build IO path be synchronized with > map updates with the host_lock. > Adam, Thanks for the clarification wrt to your latest patches. Do you think it would make sense to convert the synchronization between the build IO path and map updates to use the LLD specific instance->hba_lock instead of host_lock..? This is the method I have been employing thus far w/ with the host_lock-less conversion for megaraid_sas, and from a quick grok it appears this might be the most sane approach for MSI-X support. Any thoughts..? Best Regards, --nab