* Re: linux-next: Tree for December 27 (drivers/target/) [not found] <20101227170451.a9a9f873.sfr@canb.auug.org.au> @ 2010-12-27 19:21 ` Randy Dunlap 2010-12-27 22:47 ` Nicholas A. Bellinger 2010-12-27 19:57 ` linux-next: Tree for December 27 (drivers/target) Randy Dunlap 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2010-12-27 19:21 UTC (permalink / raw) To: Stephen Rothwell, scsi; +Cc: linux-next, LKML, nab On Mon, 27 Dec 2010 17:04:51 +1100 Stephen Rothwell wrote: > Hi all, > > [The mirroring on kernel.org is running slowly] yep :( > Changes since 20101221: When CONFIG_SCSI is not enabled: ERROR: "scsi_device_type" [drivers/target/target_core_mod.ko] undefined! from target_core_transport.c::1586: printk(" Type: %s ", scsi_device_type(device_type)); Also please update MAINTAINERS for drivers/target/. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** desserts: http://www.xenotime.net/linux/recipes/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for December 27 (drivers/target/) 2010-12-27 19:21 ` linux-next: Tree for December 27 (drivers/target/) Randy Dunlap @ 2010-12-27 22:47 ` Nicholas A. Bellinger 0 siblings, 0 replies; 5+ messages in thread From: Nicholas A. Bellinger @ 2010-12-27 22:47 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, scsi, linux-next, LKML On Mon, 2010-12-27 at 11:21 -0800, Randy Dunlap wrote: > On Mon, 27 Dec 2010 17:04:51 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > [The mirroring on kernel.org is running slowly] > > yep :( > > > Changes since 20101221: > > > When CONFIG_SCSI is not enabled: > > ERROR: "scsi_device_type" [drivers/target/target_core_mod.ko] undefined! > > from target_core_transport.c::1586: > > printk(" Type: %s ", scsi_device_type(device_type)); > Hi Randy and Stephen, As there is really no a reason for building CONFIG_TARGET_CORE w/o CONFIG_SCSI && CONFIG_BLOCK, the following patch has been added to the new linux-next target tree here: target: Add SCSI and BLOCK depends for TARGET_CORE http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=15c8da9639029ac337dd2f0bb67010de62d4b724 > > Also please update MAINTAINERS for drivers/target/. > Also added here, thanks for the reminder: target: Add drivers/target/ entry to MAINTAINERS http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=85356c6c328b3c4add3d240e387087a76a469028 Best Regards, --nab ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for December 27 (drivers/target) [not found] <20101227170451.a9a9f873.sfr@canb.auug.org.au> 2010-12-27 19:21 ` linux-next: Tree for December 27 (drivers/target/) Randy Dunlap @ 2010-12-27 19:57 ` Randy Dunlap 2010-12-27 22:49 ` Nicholas A. Bellinger 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2010-12-27 19:57 UTC (permalink / raw) To: Stephen Rothwell, nab, scsi; +Cc: linux-next, LKML On Mon, 27 Dec 2010 17:04:51 +1100 Stephen Rothwell wrote: > Hi all, > > [The mirroring on kernel.org is running slowly] > > Changes since 20101221: > > Linus' tree lost its build failure. Hi Nick, Please test building target code when CONFIG_BLOCK is not enabled. When CONFIG_BLOCK is not enabled, drivers/target/ gets a boat load of build errors. Should TCM_IBLOCK depend on BLOCK? That fixes lots of the build errors, but not all of them. The header file include/target/target_core_base.h uses struct queue_limits, so it should #include <linux/blkdev.h>. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** desserts: http://www.xenotime.net/linux/recipes/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for December 27 (drivers/target) 2010-12-27 19:57 ` linux-next: Tree for December 27 (drivers/target) Randy Dunlap @ 2010-12-27 22:49 ` Nicholas A. Bellinger 2010-12-28 15:08 ` James Bottomley 0 siblings, 1 reply; 5+ messages in thread From: Nicholas A. Bellinger @ 2010-12-27 22:49 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, scsi, linux-next, LKML On Mon, 2010-12-27 at 11:57 -0800, Randy Dunlap wrote: > On Mon, 27 Dec 2010 17:04:51 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > [The mirroring on kernel.org is running slowly] > > > > Changes since 20101221: > > > > Linus' tree lost its build failure. > > > Hi Nick, > > Please test building target code when CONFIG_BLOCK is not enabled. > > When CONFIG_BLOCK is not enabled, drivers/target/ gets a boat load of build errors. > > Should TCM_IBLOCK depend on BLOCK? That fixes lots of the build errors, > but not all of them. > > > The header file include/target/target_core_base.h uses struct queue_limits, > so it should #include <linux/blkdev.h>. > > Added the missing include here: target: Add linux/blkdev.h include in target_core_base.h http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=e8bd07d3a525e71b424d308fc5084b89a6456bb2 Thanks Randy! --nab ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for December 27 (drivers/target) 2010-12-27 22:49 ` Nicholas A. Bellinger @ 2010-12-28 15:08 ` James Bottomley 0 siblings, 0 replies; 5+ messages in thread From: James Bottomley @ 2010-12-28 15:08 UTC (permalink / raw) To: Nicholas A. Bellinger Cc: Randy Dunlap, Stephen Rothwell, scsi, linux-next, LKML On Mon, 2010-12-27 at 14:49 -0800, Nicholas A. Bellinger wrote: > On Mon, 2010-12-27 at 11:57 -0800, Randy Dunlap wrote: > > On Mon, 27 Dec 2010 17:04:51 +1100 Stephen Rothwell wrote: > > > > > Hi all, > > > > > > [The mirroring on kernel.org is running slowly] > > > > > > Changes since 20101221: > > > > > > Linus' tree lost its build failure. > > > > > > Hi Nick, > > > > Please test building target code when CONFIG_BLOCK is not enabled. > > > > When CONFIG_BLOCK is not enabled, drivers/target/ gets a boat load of build errors. > > > > Should TCM_IBLOCK depend on BLOCK? That fixes lots of the build errors, > > but not all of them. > > > > > > The header file include/target/target_core_base.h uses struct queue_limits, > > so it should #include <linux/blkdev.h>. > > > > > > Added the missing include here: > > target: Add linux/blkdev.h include in target_core_base.h > http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=e8bd07d3a525e71b424d308fc5084b89a6456bb2 > > Thanks Randy! Could you just do mod patches inline to the list, please? It's much less convenient trying to pull them out of a web page. Thanks, James ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-28 15:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20101227170451.a9a9f873.sfr@canb.auug.org.au>
2010-12-27 19:21 ` linux-next: Tree for December 27 (drivers/target/) Randy Dunlap
2010-12-27 22:47 ` Nicholas A. Bellinger
2010-12-27 19:57 ` linux-next: Tree for December 27 (drivers/target) Randy Dunlap
2010-12-27 22:49 ` Nicholas A. Bellinger
2010-12-28 15:08 ` James Bottomley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).