From: James Bottomley <James.Bottomley@suse.de>
To: roel kluin <roel.kluin@gmail.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
just.for.lkml@googlemail.com, nick.cheng@areca.com.tw,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] arcmsr: &/| confusion in arcmsr_build_ccb()
Date: Mon, 03 Jan 2011 10:43:30 -0600 [thread overview]
Message-ID: <1294073011.4721.7.camel@mulgrave.site> (raw)
In-Reply-To: <4D1F7517.7080803@gmail.com>
On Sat, 2011-01-01 at 19:40 +0100, roel kluin wrote:
> Make sure no other command which does a write, such as UNMAP and WRITE_32, is missed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> If you agree this is the right fix, please ack.
>
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 17e3df4..a5acedc 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -1171,7 +1171,7 @@ static int arcmsr_build_ccb(struct AdapterControlBlock *acb,
> arcmsr_cdb->msgPages = arccdbsize/0x100 + (arccdbsize % 0x100 ? 1 : 0);
> if ( arccdbsize > 256)
> arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_SGL_BSIZE;
> - if (pcmd->cmnd[0]|WRITE_6 || pcmd->cmnd[0]|WRITE_10 || pcmd->cmnd[0]|WRITE_12 ){
> + if (pcmd->sc_data_direction == DMA_TO_DEVICE)
> arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_WRITE;
> }
> ccb->arc_cdb_size = arccdbsize;
Compile checking patches you send in next time would be most welcome:
CC [M] drivers/scsi/arcmsr/arcmsr_hba.o
drivers/scsi/arcmsr/arcmsr_hba.c:1177:5: error: expected ‘=’, ‘,’, ‘;’,
‘asm’ or ‘__attribute__’ before ‘->’ token
drivers/scsi/arcmsr/arcmsr_hba.c:1178:2: error: expected identifier or
‘(’ before ‘return’
drivers/scsi/arcmsr/arcmsr_hba.c:1179:1: error: expected identifier or
‘(’ before ‘}’ token
drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_build_ccb’:
drivers/scsi/arcmsr/arcmsr_hba.c:1176:2: warning: control reaches end of
non-void function
James
next prev parent reply other threads:[~2011-01-03 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 16:45 [PATCH] [SCSI] arcmsr: &/| confusion in arcmsr_build_ccb() roel kluin
2011-01-01 17:08 ` Matthew Wilcox
2011-01-01 17:28 ` Torsten Kaiser
2011-01-01 23:34 ` Matthew Wilcox
2011-01-01 18:40 ` roel kluin
2011-01-03 2:35 ` NickCheng
2011-01-03 5:22 ` Torsten Kaiser
2011-01-03 16:43 ` James Bottomley [this message]
2011-01-01 17:12 ` Torsten Kaiser
2011-01-06 9:32 ` Fix the issue of system hangup after commands timeout on ARC-1200(Type_B controller) NickCheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294073011.4721.7.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=nick.cheng@areca.com.tw \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox