From: James Bottomley <James.Bottomley@suse.de>
To: "Moger, Babu" <Babu.Moger@lsi.com>
Cc: Dan Carpenter <error27@gmail.com>,
Mike Snitzer <snitzer@redhat.com>,
Menny Hamburger <Menny_Hamburger@Dell.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate()
Date: Tue, 04 Jan 2011 10:24:39 -0600 [thread overview]
Message-ID: <1294158279.4726.17.camel@mulgrave.site> (raw)
In-Reply-To: <E463DF2B2E584B4A82673F53D62C2EF4F5582F42@cosmail01.lsi.com>
On Tue, 2011-01-04 at 09:13 -0700, Moger, Babu wrote:
> Looks good to me.
It does? The first check is the bogus one, surely. The queue is
created and destroyed by scsi_alloc_sdev(), so queuedata can never be
NULL for a SCSI queue. There's no check anywhere in the rest of SCSI,
so there shouldn't be one here, should there?
James
next prev parent reply other threads:[~2011-01-04 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 5:48 [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() Dan Carpenter
2011-01-04 16:13 ` Moger, Babu
2011-01-04 16:24 ` James Bottomley [this message]
2011-01-04 19:50 ` Moger, Babu
2011-01-04 19:58 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294158279.4726.17.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=Babu.Moger@lsi.com \
--cc=Menny_Hamburger@Dell.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox