From: Robert Love <robert.w.love@intel.com>
To: Yi Zou <yi.zou@intel.com>
Cc: devel@open-fcoe.org, linux-scsi@vger.kernel.org
Subject: Re: [Open-FCoE] [PATCH v3 04/10] libfcoe: rename libfcoe.c to fcoe_cltr.c for the coming fcoe_transport.c
Date: Fri, 14 Jan 2011 17:29:07 -0800 [thread overview]
Message-ID: <1295054947.1836.4.camel@fritz> (raw)
In-Reply-To: <1295054856.1836.3.camel@fritz>
On Fri, 2011-01-14 at 17:27 -0800, Robert Love wrote:
> On Wed, 2011-01-12 at 18:20 -0800, Yi Zou wrote:
> > The existing libfcoe.c is mostly for FIP support, rename it to reflect that
> > fact and so we can add fcoe_transport.c to the make file to include both
> > into the libfcoe kernel module.
> >
> > Signed-off-by: Yi Zou <yi.zou@intel.com>
> > ---
> >
> > drivers/scsi/fcoe/fcoe_ctlr.c | 2690 +++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 2690 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/scsi/fcoe/fcoe_ctlr.c
>
> This isn't renaming the file, it's copying it. Should this patch move
> the file and then update Kconfig so that libfcoe builds?
>
OK, just saw the next patch that completes the job. I think the two
patches should be merged.
//Rob
next prev parent reply other threads:[~2011-01-15 1:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 2:19 [PATCH v3 00/10] Adding support to fcoe transport Yi Zou
2011-01-13 2:19 ` [PATCH v3 01/10] libfcoe: move logging macros into the local libfcoe.h header file Yi Zou
2011-01-13 2:19 ` [PATCH v3 02/10] libfcoe: add fcoe_transport structure defines to include/scsi/libfcoe.h Yi Zou
2011-01-13 2:19 ` [PATCH v3 03/10] libfcoe: add implementation to support fcoe transport Yi Zou
2011-01-15 1:25 ` [Open-FCoE] " Robert Love
2011-01-15 1:37 ` Zou, Yi
2011-01-13 2:20 ` [PATCH v3 04/10] libfcoe: rename libfcoe.c to fcoe_cltr.c for the coming fcoe_transport.c Yi Zou
2011-01-15 1:27 ` [Open-FCoE] " Robert Love
2011-01-15 1:29 ` Robert Love [this message]
2011-01-15 1:41 ` Zou, Yi
2011-01-13 2:20 ` [PATCH v3 05/10] libfcoe: remove libfcoe.c, use the same fcoe_ctlr.c instead Yi Zou
2011-01-13 2:20 ` [PATCH v3 06/10] libfcoe: include fcoe_transport.c into kernel libfcoe module Yi Zou
2011-01-13 2:20 ` [PATCH v3 07/10] fcoe: prepare fcoe for using fcoe transport Yi Zou
2011-01-13 2:20 ` [PATCH v3 08/10] fcoe: convert fcoe.ko to become an fcoe transport provider driver Yi Zou
2011-01-13 2:20 ` [PATCH v3 09/10] libfcoe: Handle ERESTARTSYS for fcoe transport Yi Zou
2011-01-13 2:20 ` [PATCH v3 10/10] fcoe: Return ERESTARTSYS on rtnl_trylock failure Yi Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295054947.1836.4.camel@fritz \
--to=robert.w.love@intel.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox