From: James Bottomley <James.Bottomley@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Erroneous handling of sense status in SCSI EH commands
Date: Tue, 25 Jan 2011 15:38:02 +0000 [thread overview]
Message-ID: <1295969882.4955.82.camel@mulgrave.site> (raw)
In-Reply-To: <4D3E60F0.80407@cs.wisc.edu>
On Mon, 2011-01-24 at 23:34 -0600, Mike Christie wrote:
> On 01/24/2011 11:18 PM, Mike Christie wrote:
> > On 01/24/2011 02:17 PM, Mike Christie wrote:
> >> For example, with your patch if for the
> >> scsi_send_eh_cmnd/scsi_eh_completed_normally/scsi_check_sense path we
> >> got 02/04/01 (not ready - becomming ready), scsi_send_eh_cmnd would see
> >> SOFT_ERROR and fail the scsi eh. And, I am saying don't we want retry
> >> this like we would if we were going through the normal IO path, so we do
> >> not offline devices on this type of failure?
> >>
> >
> > Just some corrections/clarifications. The device, target and bus reset
> > handling are ok, but just host reset handling seems like the problem (at
> > least the problem I was hitting I think). We do not call
> > __scsi_report_device_reset for host reset handling, but some LLD
> > eh_host_reset_handler implementations execute operations that can cause
> > us to get something like a UA for the scsi eh TUR. For your patch do you
> > also want to call __scsi_report_device_reset for the host reset handling
> > for these drivers then?
>
> Ignore that. I see it is getting called for the host reset code. I am
> not sure what happened when I was testing it.
Just so I'm clear ... that's you withdrawing all objections to this
patch, so I can put it in scsi-misc for testing?
James
next prev parent reply other threads:[~2011-01-25 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 8:07 [PATCH] scsi: Erroneous handling of sense status in SCSI EH commands Hannes Reinecke
2011-01-21 20:49 ` Mike Christie
2011-01-24 7:59 ` Hannes Reinecke
2011-01-24 20:17 ` Mike Christie
2011-01-25 5:18 ` Mike Christie
2011-01-25 5:34 ` Mike Christie
2011-01-25 15:38 ` James Bottomley [this message]
2011-01-25 20:19 ` Mike Christie
2011-02-12 16:30 ` James Bottomley
2011-02-14 7:26 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295969882.4955.82.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).