From: James Bottomley <James.Bottomley@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Brian King <brking@linux.vnet.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-ide <linux-ide@vger.kernel.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Wayne Boyer <wayneb@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/2] convert libsas to the libata new eh
Date: Wed, 26 Jan 2011 12:55:49 -0500 [thread overview]
Message-ID: <1296064549.4893.75.camel@mulgrave.site> (raw)
In-Reply-To: <4D405E06.5020400@garzik.org>
On Wed, 2011-01-26 at 12:46 -0500, Jeff Garzik wrote:
> On 01/26/2011 09:08 AM, James Bottomley wrote:
> > I think better might be to move the eh thread functionality into block.
> > What libata really wants is one eh thread per phy. It gets this by
> [...]
> > machinery, everyone should get what they want, and libata could dispense
> > with its current corruption of multiple SCSI hosts per physical bus
> > attachment.
>
> That's not the whole picture. libata originally chose one-host-per-port
> because that winds up being the best queueing/queue-busy arrangement for
> legacy IDE ports.
Right, but we count things at the lun, the target and the host. For a
two level queue setup, you could use the target.
> They behave quite similarly to independent
> controllers -- even to the point of having separate irqs -- even though
> multiple IDE ports are shoehorned into a single PCI device.
So interrupts don't really have much to do with the host, that's all
part of driver setup. IDE is really just using the two lines as a
simple completion signal ... much like the current multi queue cards do
(which also have multiple interrupts per host).
James
next prev parent reply other threads:[~2011-01-26 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 15:41 [PATCH 0/2] convert libsas to the libata new eh James Bottomley
2011-01-23 15:42 ` [PATCH 1/2] libata: separate error handler into usable components James Bottomley
2011-01-23 15:44 ` [PATCH 2/2] libsas: convert to libata new error handler James Bottomley
2011-01-24 21:12 ` [PATCH 0/2] convert libsas to the libata new eh Jeff Garzik
2011-01-24 21:16 ` James Bottomley
2011-01-25 18:56 ` Brian King
2011-01-26 14:08 ` James Bottomley
2011-01-26 17:46 ` Jeff Garzik
2011-01-26 17:55 ` James Bottomley [this message]
2011-02-13 19:18 ` James Bottomley
2011-02-15 7:03 ` Jeff Garzik
2011-02-15 14:15 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296064549.4893.75.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=brking@linux.vnet.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=wayneb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).