From: James Bottomley <James.Bottomley@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] libsas: convert to standard kernel debugging
Date: Wed, 26 Jan 2011 20:24:36 +0000 [thread overview]
Message-ID: <1296073476.4893.80.camel@mulgrave.site> (raw)
In-Reply-To: <20110126202157.GA11101@infradead.org>
On Wed, 2011-01-26 at 15:21 -0500, Christoph Hellwig wrote:
> On Sun, Jan 23, 2011 at 08:19:00AM -0600, James Bottomley wrote:
> > Instead of using a config option for debugging, just dump the
> > messages with KERN_DEBUG.
>
> SAS_DPRINTK is far too verbose to just enable it all the time
> and fill the kernel log buffer.
It's less verbose than the PM stuff. It actually only prints mostly at
either discovery or error time. It's pretty much silent during normal
operation.
> Some of it would be a good fit
> for tracepoints, and some of should simply be removed.
Possibly ... I'll look into that later.
James
prev parent reply other threads:[~2011-01-26 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 14:19 [PATCH] libsas: convert to standard kernel debugging James Bottomley
2011-01-26 20:21 ` Christoph Hellwig
2011-01-26 20:24 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296073476.4893.80.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox