linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: linux-scsi <linux-scsi@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Joel Becker <jlbec@evilplan.org>,
	Fubo Chen <fubo.chen@gmail.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH 0/4] target: Move backend memory release to configfs_item_operations->release()
Date: Wed,  2 Feb 2011 00:26:47 -0800	[thread overview]
Message-ID: <1296635211-6269-1-git-send-email-nab@linux-iscsi.org> (raw)

From: Nicholas Bellinger <nab@linux-iscsi.org>

Greetings all,

This series addresses four scenarios in backend HBA/DEV target_core_configfs.c
code where config_item_put() being called upon the following TCM config_groups:

	struct se_hba->hba_group

	struct se_subsystem_dev->se_dev_group

	struct t10_alua_lu_gp->lu_gp_group

	struct t10_alua_tg_pt_gp->tg_pt_gp_group

and subsequently releasing memory of these four parent TCM data structures
is causing a number of SLUB 'Poison overwritten' warnings during slub_debug=FPUZ
testing with .38-rc2 code.

This series addresses the issue by using moving existing release logic
of the parent structure containing a struct_config_group into it's own
seperate struct configfs_item_operations->release() callback.

Please review and comment,

Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>

Nicholas Bellinger (4):
  target: Move core_delete_hba() into ->release() callback
  target: Move subdev release logic into ->release() callback
  target: Move core_alua_free_lu_gp() into ->release() callback
  target: Move core_alua_free_tg_pt_gp() into ->release() callback

 drivers/target/target_core_configfs.c |  114 +++++++++++++++++++++------------
 1 files changed, 73 insertions(+), 41 deletions(-)


             reply	other threads:[~2011-02-02  8:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02  8:26 Nicholas A. Bellinger [this message]
2011-02-02  8:26 ` [PATCH 1/4] target: Move core_delete_hba() into ->release() callback Nicholas A. Bellinger
2011-02-02  8:26 ` [PATCH 2/4] target: Move subdev release logic " Nicholas A. Bellinger
2011-02-03 19:48   ` Fubo Chen
2011-02-03 21:19     ` Nicholas A. Bellinger
2011-02-05  9:16       ` Fubo Chen
2011-02-05 23:18         ` Nicholas A. Bellinger
2011-02-02  8:26 ` [PATCH 3/4] target: Move core_alua_free_lu_gp() " Nicholas A. Bellinger
2011-02-02  8:26 ` [PATCH 4/4] target: Move core_alua_free_tg_pt_gp() " Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296635211-6269-1-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=fubo.chen@gmail.com \
    --cc=hch@lst.de \
    --cc=jlbec@evilplan.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).