Re: [PATCH 1/3] qla2xxx: Remove check to return DID_NO_CONNECT when FC device is lost.

[James Bottomley <James.Bottomley@suse.de>]

On Fri, 2011-01-28 at 15:17 -0800, madhu.iyengar@qlogic.com wrote:
> From: Andrew Vasquez <andrew.vasquez@qlogic.com>
> 
> Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Signed-off-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com>
> ---
>  drivers/scsi/qla2xxx/qla_os.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index c194c23..5dc548b 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -562,7 +562,6 @@ qla2xxx_queuecommand_lck(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *)
>  	}
>  	if (atomic_read(&fcport->state) != FCS_ONLINE) {
>  		if (atomic_read(&fcport->state) == FCS_DEVICE_DEAD ||
> -			atomic_read(&fcport->state) == FCS_DEVICE_LOST ||

This looks like you're actually *not* returning DID_NO_CONNECT when the
device is lost ... what are you returning instead, and why is this an
important bug fix?

James


>  			atomic_read(&base_vha->loop_state) == LOOP_DEAD) {
>  			cmd->result = DID_NO_CONNECT << 16;
>  			goto qc24_fail_command;