Re: [PATCH 01/06] mptfusion: (New Feature)Added new sysfs parameters for handle and firmware id

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Thu, 2011-02-10 at 11:49 +0530, Kashyap, Desai wrote:
> New feature is added.  sas_device_hanlde and firmware id will be visible from 
> sysfs parameters. handle and firmware id is internal to LSI firmware.
> It is merely debugging purpose.

Broken record time: checkpatch.pl:

WARNING: please, no space before tabs
#21: FILE: drivers/message/fusion/mptbase.h:402:
+^Iu16     ^I^I handle;$

WARNING: please, no spaces at the start of a line
#67: FILE: drivers/message/fusion/mptscsih.c:3350:
+    char *buf)$

ERROR: code indent should use tabs where possible
#79: FILE: drivers/message/fusion/mptscsih.c:3362:
+ ^I^INULL);$

WARNING: please, no space before tabs
#79: FILE: drivers/message/fusion/mptscsih.c:3362:
+ ^I^INULL);$

WARNING: please, no spaces at the start of a line
#79: FILE: drivers/message/fusion/mptscsih.c:3362:
+ ^I^INULL);$

WARNING: please, no spaces at the start of a line
#91: FILE: drivers/message/fusion/mptscsih.c:3374:
+    char *buf)$

ERROR: code indent should use tabs where possible
#103: FILE: drivers/message/fusion/mptscsih.c:3386:
+ ^I^INULL);$

WARNING: please, no space before tabs
#103: FILE: drivers/message/fusion/mptscsih.c:3386:
+ ^I^INULL);$

WARNING: please, no spaces at the start of a line
#103: FILE: drivers/message/fusion/mptscsih.c:3386:
+ ^I^INULL);$

total: 2 errors, 7 warnings, 93 lines checked

Also, as I read through this patch, doesn't it add these two parameters
for every fusion device type (SPI, SAS and FC) but only set them for
SAS?  If you want SAS only parameters, they should probably be visible
only for SAS cards.

James