From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH-FOR-38] target: Fix t_transport_aborted handling in LUN_RESET + active I/O shutdown
Date: Mon, 28 Feb 2011 11:29:35 -0600 [thread overview]
Message-ID: <1298914175.2487.42.camel@mulgrave.site> (raw)
In-Reply-To: <1298595500-1558-1-git-send-email-nab@linux-iscsi.org>
On Thu, 2011-02-24 at 16:58 -0800, Nicholas A. Bellinger wrote:
> atomic_set(&task->task_stop, 0);
> + } else {
> + if (atomic_read(&task->task_execute_queue) != 0)
> + transport_remove_task_from_execute_queue(task, dev);
You've done this twice in this patch; just for future reference, it's
better written as
} else if (atomic_read(&task->task_execute_queue) != 0) {
transport_remove_task_from_execute_queue(task, dev);
}
Which avoids the double indentation.
James
next prev parent reply other threads:[~2011-02-28 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 0:58 [PATCH-FOR-38] target: Fix t_transport_aborted handling in LUN_RESET + active I/O shutdown Nicholas A. Bellinger
2011-02-28 17:29 ` James Bottomley [this message]
2011-02-28 19:37 ` Bart Van Assche
2011-02-28 23:28 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298914175.2487.42.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).