From: James Bottomley <James.Bottomley@suse.de>
To: adam radford <aradford@gmail.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, Bo.Yang@lsi.com
Subject: Re: [PATCH 6/14] megaraid_sas: Fix megasas_get_cmd printk
Date: Mon, 28 Feb 2011 11:50:23 -0600 [thread overview]
Message-ID: <1298915423.2487.43.camel@mulgrave.site> (raw)
In-Reply-To: <AANLkTimMuwYPbmear_zD49_=h7HhSy4NHg9hYh8esLSN@mail.gmail.com>
On Thu, 2011-02-24 at 20:56 -0800, adam radford wrote:
> James/Linux-scsi,
>
> The following patch for megaraid_sas fixes a megasas_get_cmd printk.
>
> Signed-off-by: Adam Radford <aradford@gmail.com>
>
> diff -Naur scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_base.c
> scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_base.c
> --- scsi-misc-2.6/drivers/scsi/megaraid/megaraid_sas_base.c 2011-02-24
> 18:49:07.531369391 -0800
> +++ scsi-misc-2.6.new/drivers/scsi/megaraid/megaraid_sas_base.c 2011-02-24
> 18:49:45.987337951 -0800
> @@ -186,7 +186,8 @@
> struct megasas_cmd, list);
> list_del_init(&cmd->list);
> } else {
> - printk(KERN_ERR "megasas: Command pool empty!\n");
> + if (megasas_dbg_lvl)
> + printk(KERN_ERR "megasas: Command pool empty!\n");
Why not just use KERN_DEBUG instead of KERN_ERR here and forget the if
(megasas_dbg_lvl)?
James
prev parent reply other threads:[~2011-02-28 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 4:56 [PATCH 6/14] megaraid_sas: Fix megasas_get_cmd printk adam radford
2011-02-28 17:50 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298915423.2487.43.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=Bo.Yang@lsi.com \
--cc=aradford@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox