From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99027CD37AD for ; Fri, 15 Sep 2023 21:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234089AbjIOVgk (ORCPT ); Fri, 15 Sep 2023 17:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237867AbjIOVgO (ORCPT ); Fri, 15 Sep 2023 17:36:14 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72D3118E for ; Fri, 15 Sep 2023 14:36:04 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 34D191FD7E; Fri, 15 Sep 2023 21:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1694813763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h6XZeP7YD8ux9Te81NL/TcsWAwV61TWDazpItV3NOgE=; b=rcxreTnPGWikJYaQCGKnL42vfBNx5E1yhltzxaymDO2LGSho6W6Kd2lEDDufy+G2YLioLG Na6wL9eqda/K/R8M3gBEWgN3bEhuLrpFEQj85h9RJWVKXUPdmpYyNAXsslwz66nnavWpAd eVQTl3rT52YFrrPpbR8Lyk9z/Q0aPRc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC3B313251; Fri, 15 Sep 2023 21:36:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PqIkOELOBGWnKQAAMHmgww (envelope-from ); Fri, 15 Sep 2023 21:36:02 +0000 Message-ID: <129c6d0797b25659db139014d524d9896c0b3ac3.camel@suse.com> Subject: Re: [PATCH v11 28/34] scsi: sr: Have scsi-ml retry get_sectorsize errors From: Martin Wilck To: Mike Christie , john.g.garry@oracle.com, bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com Date: Fri, 15 Sep 2023 23:36:02 +0200 In-Reply-To: <20230905231547.83945-29-michael.christie@oracle.com> References: <20230905231547.83945-1-michael.christie@oracle.com> <20230905231547.83945-29-michael.christie@oracle.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, 2023-09-05 at 18:15 -0500, Mike Christie wrote: > This has get_sectorsize have scsi-ml retry errors instead of driving > them > itself. >=20 > There is one behavior change where we no longer retry when > scsi_execute_cmd returns < 0, but we should be ok. We don't need to > retry > for failures like the queue being removed, and for the case where > there > are no tags/reqs the block layer waits/retries for us. For possible > memory > allocation failures from blk_rq_map_kern we use GFP_NOIO, so retrying > will probably not help. >=20 > Signed-off-by: Mike Christie > Reviewed-by: Christoph Hellwig Reviewed-by: Martin Wilck