From: "Tony Luck" <tony.luck@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, fischer@norbit.de, linux-scsi@vger.kernel.org
Subject: Re: [PATCH, RFC] hide EH backup data outside the scsi_cmnd
Date: Mon, 24 Jul 2006 10:27:55 -0700 [thread overview]
Message-ID: <12c511ca0607241027y39498f37le4e5f2b320e01e4a@mail.gmail.com> (raw)
In-Reply-To: <20060603112610.GB17018@lst.de>
On 6/3/06, Christoph Hellwig <hch@lst.de> wrote:
> Currently struct scsi_cmnd has various fields that are used to backup
> original data after the corresponding fields have been overridden for
> EH commands. This means drivers can easily get at it and misuse it.
> Due to the old_ naming this doesn't happen for most of them, but two
> that have different names have been used wrong a lot (see previous
> patch).
I guess that I'm an abuser :-(
> Index: scsi-misc-2.6/include/scsi/scsi_cmnd.h
> - void *buffer; /* Data buffer */
arch/ia64/hp/sim/simscsi.c is still using this (and so doesn't compile
now that this change has hit mainline). It seems that simscsi.c is
expecting to find a "scatterlist" there ... but looking at the rest of
the patch that removed this element, it isn't obvious where it went.
-Tony
next prev parent reply other threads:[~2006-07-24 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060603112610.GB17018@lst.de>
2006-06-03 11:31 ` [PATCH, RFC] hide EH backup data outside the scsi_cmnd Christoph Hellwig
2006-06-10 16:08 ` Christoph Hellwig
2006-06-12 19:19 ` Christoph Hellwig
2006-06-14 2:31 ` James Bottomley
2006-06-14 2:40 ` James Bottomley
2006-06-14 2:43 ` James Bottomley
2006-06-14 18:43 ` FUJITA Tomonori
2006-06-14 19:03 ` Mike Christie
2006-06-16 6:31 ` FUJITA Tomonori
2006-06-20 7:49 ` FUJITA Tomonori
2006-07-24 17:27 ` Tony Luck [this message]
2006-07-24 19:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c511ca0607241027y39498f37le4e5f2b320e01e4a@mail.gmail.com \
--to=tony.luck@intel.com \
--cc=fischer@norbit.de \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox