Re: fcoe: correct checking for bonding

Jiri Pirko
2011-03-02T09:56:04Z

Or perhaps this should be applied to net-next?

Wed, Mar 02, 2011 at 07:05:35AM CET, jpirko@redhat.com wrote:
>Check for bonding master and refuse to use that.
>
>Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>---
> drivers/scsi/fcoe/fcoe.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
>index 9f9600b..3becc6a 100644
>--- a/drivers/scsi/fcoe/fcoe.c
>+++ b/drivers/scsi/fcoe/fcoe.c
>@@ -285,9 +285,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
> }
>
> /* Do not support for bonding device */
>- if ((netdev->priv_flags & IFF_MASTER_ALB) ||
>- (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
>- (netdev->priv_flags & IFF_MASTER_8023AD)) {
>+ if (netdev->priv_flags & IFF_BONDING && netdev->flags & IFF_MASTER) {
> FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
> return -EOPNOTSUPP;
> }
>--
>1.7.3.4
>