* [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination [not found] ` <1300229605-14499-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> @ 2011-03-15 22:53 ` Kirill A. Shutemov 2011-03-15 23:52 ` Robert Love 2011-03-15 23:57 ` [PATCH] " Robert Love 0 siblings, 2 replies; 5+ messages in thread From: Kirill A. Shutemov @ 2011-03-15 22:53 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Kirill A. Shutemov, James E.J. Bottomley, linux-scsi-u79uwXL29TY76Z2rM5mHXA, devel-s9riP+hp16TNLxjTenLetw Signed-off-by: Kirill A. Shutemov <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> Cc: "James E.J. Bottomley" <James.Bottomley-l3A5Bk7waGM@public.gmane.org> Cc: Robert Love <robert.w.love-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devel-s9riP+hp16TNLxjTenLetw@public.gmane.org --- drivers/scsi/esp_scsi.c | 6 ++---- drivers/scsi/fcoe/libfcoe.c | 6 ++---- drivers/scsi/scsi_tgt_lib.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c index 5755852..9a1af1d 100644 --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -708,8 +708,7 @@ static void esp_maybe_execute_command(struct esp *esp) tp = &esp->target[tgt]; lp = dev->hostdata; - list_del(&ent->list); - list_add(&ent->list, &esp->active_cmds); + list_move(&ent->list, &esp->active_cmds); esp->active_cmd = ent; @@ -1244,8 +1243,7 @@ static int esp_finish_select(struct esp *esp) /* Now that the state is unwound properly, put back onto * the issue queue. This command is no longer active. */ - list_del(&ent->list); - list_add(&ent->list, &esp->queued_cmds); + list_move(&ent->list, &esp->queued_cmds); esp->active_cmd = NULL; /* Return value ignored by caller, it directly invokes diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c index 625c6be..a1f7025 100644 --- a/drivers/scsi/fcoe/libfcoe.c +++ b/drivers/scsi/fcoe/libfcoe.c @@ -1004,10 +1004,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb) * the FCF that answers multicast solicitations, not the others that * are sending periodic multicast advertisements. */ - if (mtu_valid) { - list_del(&fcf->list); - list_add(&fcf->list, &fip->fcfs); - } + if (mtu_valid) + list_move(&fcf->list, &fip->fcfs); /* * If this is the first validated FCF, note the time and diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c index c399be9..4c444b8 100644 --- a/drivers/scsi/scsi_tgt_lib.c +++ b/drivers/scsi/scsi_tgt_lib.c @@ -275,10 +275,8 @@ void scsi_tgt_free_queue(struct Scsi_Host *shost) for (i = 0; i < ARRAY_SIZE(qdata->cmd_hash); i++) { list_for_each_entry_safe(tcmd, n, &qdata->cmd_hash[i], - hash_list) { - list_del(&tcmd->hash_list); - list_add(&tcmd->hash_list, &cmds); - } + hash_list) + list_move(&tcmd->hash_list, &cmds); } spin_unlock_irqrestore(&qdata->cmd_hash_lock, flags); -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination 2011-03-15 22:53 ` [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination Kirill A. Shutemov @ 2011-03-15 23:52 ` Robert Love 2011-03-15 23:57 ` [PATCH] " Robert Love 1 sibling, 0 replies; 5+ messages in thread From: Robert Love @ 2011-03-15 23:52 UTC (permalink / raw) To: Kirill A. Shutemov Cc: linux-kernel@vger.kernel.org, James E.J. Bottomley, linux-scsi@vger.kernel.org, devel@open-fcoe.org On Tue, 2011-03-15 at 15:53 -0700, Kirill A. Shutemov wrote: > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> > Cc: "James E.J. Bottomley" <James.Bottomley@suse.de> > Cc: Robert Love <robert.w.love@intel.com> > Cc: linux-scsi@vger.kernel.org > Cc: devel@open-fcoe.org > --- > drivers/scsi/esp_scsi.c | 6 ++---- > drivers/scsi/fcoe/libfcoe.c | 6 ++---- Hi Kirill, libfcoe.c doesn't exist anymore in the scsi-misc tree with recent fcoe transport changes. Specifically, the change you're trying to make should be to fcoe_ctlr.c. I'll resend an updated patch that applies to scsi-misc and has my Ack. Thanks, //Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] scsi: use list_move() instead of list_del()/list_add() combination 2011-03-15 22:53 ` [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination Kirill A. Shutemov 2011-03-15 23:52 ` Robert Love @ 2011-03-15 23:57 ` Robert Love 2011-03-16 1:52 ` James Bottomley 1 sibling, 1 reply; 5+ messages in thread From: Robert Love @ 2011-03-15 23:57 UTC (permalink / raw) To: kirill; +Cc: James.Bottomley, linux-kernel, linux-scsi, devel From: Kirill A. Shutemov <kirill@shutemov.name> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> Cc: "James E.J. Bottomley" <James.Bottomley@suse.de> Cc: Robert Love <robert.w.love@intel.com> Cc: linux-scsi@vger.kernel.org Cc: devel@open-fcoe.org Acked-by: Robert Love <robert.w.love@intel.com> --- drivers/scsi/esp_scsi.c | 6 ++---- drivers/scsi/fcoe/fcoe_ctlr.c | 6 ++---- drivers/scsi/scsi_tgt_lib.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c index 5755852..9a1af1d 100644 --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -708,8 +708,7 @@ static void esp_maybe_execute_command(struct esp *esp) tp = &esp->target[tgt]; lp = dev->hostdata; - list_del(&ent->list); - list_add(&ent->list, &esp->active_cmds); + list_move(&ent->list, &esp->active_cmds); esp->active_cmd = ent; @@ -1244,8 +1243,7 @@ static int esp_finish_select(struct esp *esp) /* Now that the state is unwound properly, put back onto * the issue queue. This command is no longer active. */ - list_del(&ent->list); - list_add(&ent->list, &esp->queued_cmds); + list_move(&ent->list, &esp->queued_cmds); esp->active_cmd = NULL; /* Return value ignored by caller, it directly invokes diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index c93f007..fb3a506 100644 --- a/drivers/scsi/fcoe/fcoe_ctlr.c +++ b/drivers/scsi/fcoe/fcoe_ctlr.c @@ -978,10 +978,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb) * the FCF that answers multicast solicitations, not the others that * are sending periodic multicast advertisements. */ - if (mtu_valid) { - list_del(&fcf->list); - list_add(&fcf->list, &fip->fcfs); - } + if (mtu_valid) + list_move(&fcf->list, &fip->fcfs); /* * If this is the first validated FCF, note the time and diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c index c399be9..4c444b8 100644 --- a/drivers/scsi/scsi_tgt_lib.c +++ b/drivers/scsi/scsi_tgt_lib.c @@ -275,10 +275,8 @@ void scsi_tgt_free_queue(struct Scsi_Host *shost) for (i = 0; i < ARRAY_SIZE(qdata->cmd_hash); i++) { list_for_each_entry_safe(tcmd, n, &qdata->cmd_hash[i], - hash_list) { - list_del(&tcmd->hash_list); - list_add(&tcmd->hash_list, &cmds); - } + hash_list) + list_move(&tcmd->hash_list, &cmds); } spin_unlock_irqrestore(&qdata->cmd_hash_lock, flags); ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: use list_move() instead of list_del()/list_add() combination 2011-03-15 23:57 ` [PATCH] " Robert Love @ 2011-03-16 1:52 ` James Bottomley 2011-03-16 21:00 ` Robert Love 0 siblings, 1 reply; 5+ messages in thread From: James Bottomley @ 2011-03-16 1:52 UTC (permalink / raw) To: Robert Love; +Cc: kirill, linux-kernel, linux-scsi, devel On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote: > From: Kirill A. Shutemov <kirill@shutemov.name> > > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> > Cc: "James E.J. Bottomley" <James.Bottomley@suse.de> > Cc: Robert Love <robert.w.love@intel.com> > Cc: linux-scsi@vger.kernel.org > Cc: devel@open-fcoe.org You can junk the cc's; they're mostly annotations for git-send-email > Acked-by: Robert Love <robert.w.love@intel.com> And this has to be Signed-off-by not Acked-by. The reason is that you've resent the patch (and altered it as you transmitted it) so that makes you part of the signoff chain. If you ack a patch, it means I can pick it up from source and you as maintainer didn't actually touch it. James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: use list_move() instead of list_del()/list_add() combination 2011-03-16 1:52 ` James Bottomley @ 2011-03-16 21:00 ` Robert Love 0 siblings, 0 replies; 5+ messages in thread From: Robert Love @ 2011-03-16 21:00 UTC (permalink / raw) To: James Bottomley Cc: kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, devel@open-fcoe.org On Tue, 2011-03-15 at 18:52 -0700, James Bottomley wrote: > On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote: > > From: Kirill A. Shutemov <kirill@shutemov.name> > > > > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> > > Cc: "James E.J. Bottomley" <James.Bottomley@suse.de> > > Cc: Robert Love <robert.w.love@intel.com> > > Cc: linux-scsi@vger.kernel.org > > Cc: devel@open-fcoe.org > > You can junk the cc's; they're mostly annotations for git-send-email > > > Acked-by: Robert Love <robert.w.love@intel.com> > > And this has to be Signed-off-by not Acked-by. The reason is that > you've resent the patch (and altered it as you transmitted it) so that > makes you part of the signoff chain. If you ack a patch, it means I can > pick it up from source and you as maintainer didn't actually touch it. > Thanks for the clarification James. Signed-off-by: Robert Love <robert.w.love@intel.com> Let me know if you, or anyone else, wants me to resend the patch with the Signed-off line. //Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-16 21:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1300229605-14499-1-git-send-email-kirill@shutemov.name>
[not found] ` <1300229605-14499-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-03-15 22:53 ` [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination Kirill A. Shutemov
2011-03-15 23:52 ` Robert Love
2011-03-15 23:57 ` [PATCH] " Robert Love
2011-03-16 1:52 ` James Bottomley
2011-03-16 21:00 ` Robert Love
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).