From: Robert Love <robert.w.love@intel.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: "kirill@shutemov.name" <kirill@shutemov.name>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"devel@open-fcoe.org" <devel@open-fcoe.org>
Subject: Re: [PATCH] scsi: use list_move() instead of list_del()/list_add() combination
Date: Wed, 16 Mar 2011 14:00:45 -0700 [thread overview]
Message-ID: <1300309245.19083.399.camel@fritz> (raw)
In-Reply-To: <1300240329.13316.27.camel@mulgrave.site>
On Tue, 2011-03-15 at 18:52 -0700, James Bottomley wrote:
> On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote:
> > From: Kirill A. Shutemov <kirill@shutemov.name>
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>
> > Cc: Robert Love <robert.w.love@intel.com>
> > Cc: linux-scsi@vger.kernel.org
> > Cc: devel@open-fcoe.org
>
> You can junk the cc's; they're mostly annotations for git-send-email
>
> > Acked-by: Robert Love <robert.w.love@intel.com>
>
> And this has to be Signed-off-by not Acked-by. The reason is that
> you've resent the patch (and altered it as you transmitted it) so that
> makes you part of the signoff chain. If you ack a patch, it means I can
> pick it up from source and you as maintainer didn't actually touch it.
>
Thanks for the clarification James.
Signed-off-by: Robert Love <robert.w.love@intel.com>
Let me know if you, or anyone else, wants me to resend the patch with
the Signed-off line.
//Rob
prev parent reply other threads:[~2011-03-16 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1300229605-14499-1-git-send-email-kirill@shutemov.name>
[not found] ` <1300229605-14499-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-03-15 22:53 ` [PATCH 05/13] scsi: use list_move() instead of list_del()/list_add() combination Kirill A. Shutemov
2011-03-15 23:52 ` Robert Love
2011-03-15 23:57 ` [PATCH] " Robert Love
2011-03-16 1:52 ` James Bottomley
2011-03-16 21:00 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300309245.19083.399.camel@fritz \
--to=robert.w.love@intel.com \
--cc=James.Bottomley@suse.de \
--cc=devel@open-fcoe.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).