From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Love Subject: Re: [PATCH] scsi: use list_move() instead of list_del()/list_add() combination Date: Wed, 16 Mar 2011 14:00:45 -0700 Message-ID: <1300309245.19083.399.camel@fritz> References: <1300229605-14499-5-git-send-email-kirill@shutemov.name> <20110315235710.16992.33761.stgit@localhost6.localdomain6> <1300240329.13316.27.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:24804 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204Ab1CPVAp (ORCPT ); Wed, 16 Mar 2011 17:00:45 -0400 In-Reply-To: <1300240329.13316.27.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: "kirill@shutemov.name" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "devel@open-fcoe.org" On Tue, 2011-03-15 at 18:52 -0700, James Bottomley wrote: > On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote: > > From: Kirill A. Shutemov > > > > Signed-off-by: Kirill A. Shutemov > > Cc: "James E.J. Bottomley" > > Cc: Robert Love > > Cc: linux-scsi@vger.kernel.org > > Cc: devel@open-fcoe.org > > You can junk the cc's; they're mostly annotations for git-send-email > > > Acked-by: Robert Love > > And this has to be Signed-off-by not Acked-by. The reason is that > you've resent the patch (and altered it as you transmitted it) so that > makes you part of the signoff chain. If you ack a patch, it means I can > pick it up from source and you as maintainer didn't actually touch it. > Thanks for the clarification James. Signed-off-by: Robert Love Let me know if you, or anyone else, wants me to resend the patch with the Signed-off line. //Rob