[PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6

[PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6

[Vikas Chaudhary]

James,

Please apply these patches on scsi-misc-2.6 tree.

Karen Higgins (2):
      qla4xxx: cleanup DDB relogin logic during initialization
      qla4xxx: Prevent other port reinitialization during remove_adapter

Prasanna Mumbai (3):
      qla4xxx: Do not send mbox command if FW is in failed state
      qla4xxx: Do not retry ISP82XX initialization if H/W state is failed
      qla4xxx: masking required bits of add_fw_options during initialization

Sarang Radke (1):
      qla4xxx: Use polling mode for disable interrupt mailbox completion

Vikas Chaudhary (7):
      qla4xxx: cleanup qla4xxx_initialize_ddb_list()
      qla4xxx: remove unused ddb flag DF_NO_RELOGIN
      qla4xxx: cleanup function qla4xxx_process_ddb_changed
      qla4xxx: Add support for ql4xmaxqdepth command line parameter
      qla4xxx: add support for ql4xsess_recovery_tmo cmd line param
      qla4xxx: added new function qla4xxx_relogin_all_devices
      qla4xxx: Update driver version to 5.02.00-k6

 drivers/scsi/qla4xxx/ql4_def.h     |   10 +--
 drivers/scsi/qla4xxx/ql4_fw.h      |    1 +
 drivers/scsi/qla4xxx/ql4_glbl.h    |    1 -
 drivers/scsi/qla4xxx/ql4_init.c    |  207 ++++++------------------------------
 drivers/scsi/qla4xxx/ql4_isr.c     |   31 +-----
 drivers/scsi/qla4xxx/ql4_mbx.c     |   34 ++++--
 drivers/scsi/qla4xxx/ql4_nx.c      |    3 +-
 drivers/scsi/qla4xxx/ql4_os.c      |  155 ++++++++++++++++++---------
 drivers/scsi/qla4xxx/ql4_version.h |    2 +-
 9 files changed, 170 insertions(+), 274 deletions(-)

Thanks,
Vikas.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6

[Mike Christie]

On 03/14/2011 12:23 AM, Vikas Chaudhary wrote:
> James,
>
> Please apply these patches on scsi-misc-2.6 tree.
>
> Karen Higgins (2):
>        qla4xxx: cleanup DDB relogin logic during initialization
>        qla4xxx: Prevent other port reinitialization during remove_adapter
>
> Prasanna Mumbai (3):
>        qla4xxx: Do not send mbox command if FW is in failed state
>        qla4xxx: Do not retry ISP82XX initialization if H/W state is failed
>        qla4xxx: masking required bits of add_fw_options during initialization
>
> Sarang Radke (1):
>        qla4xxx: Use polling mode for disable interrupt mailbox completion
>
> Vikas Chaudhary (7):
>        qla4xxx: cleanup qla4xxx_initialize_ddb_list()
>        qla4xxx: remove unused ddb flag DF_NO_RELOGIN
>        qla4xxx: cleanup function qla4xxx_process_ddb_changed
>        qla4xxx: Add support for ql4xmaxqdepth command line parameter
>        qla4xxx: add support for ql4xsess_recovery_tmo cmd line param
>        qla4xxx: added new function qla4xxx_relogin_all_devices
>        qla4xxx: Update driver version to 5.02.00-k6
>

Patches look ok with updated 06/13 patch. James, Vikas actually sent a 
couple revisions of 06/13. The final one is here:
http://marc.info/?l=linux-scsi&m=130035150917342&w=2

I could not compile/checkpatch test the patches, because my 
mailer/browser keeps replacing = with =D. Other people seem to be able 
to see it ok, so I think it is problem on my side. Code was reviewed.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

Re: [PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6

[James Bottomley]

On Thu, 2011-03-17 at 22:49 -0500, Mike Christie wrote:
> On 03/14/2011 12:23 AM, Vikas Chaudhary wrote:
> > James,
> >
> > Please apply these patches on scsi-misc-2.6 tree.
> >
> > Karen Higgins (2):
> >        qla4xxx: cleanup DDB relogin logic during initialization
> >        qla4xxx: Prevent other port reinitialization during remove_adapter
> >
> > Prasanna Mumbai (3):
> >        qla4xxx: Do not send mbox command if FW is in failed state
> >        qla4xxx: Do not retry ISP82XX initialization if H/W state is failed
> >        qla4xxx: masking required bits of add_fw_options during initialization
> >
> > Sarang Radke (1):
> >        qla4xxx: Use polling mode for disable interrupt mailbox completion
> >
> > Vikas Chaudhary (7):
> >        qla4xxx: cleanup qla4xxx_initialize_ddb_list()
> >        qla4xxx: remove unused ddb flag DF_NO_RELOGIN
> >        qla4xxx: cleanup function qla4xxx_process_ddb_changed
> >        qla4xxx: Add support for ql4xmaxqdepth command line parameter
> >        qla4xxx: add support for ql4xsess_recovery_tmo cmd line param
> >        qla4xxx: added new function qla4xxx_relogin_all_devices
> >        qla4xxx: Update driver version to 5.02.00-k6
> >
> 
> Patches look ok with updated 06/13 patch. James, Vikas actually sent a 
> couple revisions of 06/13. The final one is here:
> http://marc.info/?l=linux-scsi&m=130035150917342&w=2
> 
> I could not compile/checkpatch test the patches, because my 
> mailer/browser keeps replacing = with =D. Other people seem to be able 
> to see it ok, so I think it is problem on my side. Code was reviewed.

I don't think that's entirely your fault.  This entire patch series is
whitespace damaged.  Vikas, please resubmit with the correct mailer
settings so it can be applied.

> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

I'll add this to the resubmit, thanks!

James

RE: [PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6

[Vikas Chaudhary]

>-----Original Message-----
>From: James Bottomley [mailto:James.Bottomley@suse.de]
>Sent: Saturday, March 19, 2011 8:20 PM
>To: Mike Christie
>Cc: Vikas Chaudhary; linux-scsi@vger.kernel.org; Ravi Anand; Lalit
>Chandivade; Karen Higgins; Prasanna Mumbai; Sarang Radke
>Subject: Re: [PATCH 00/13] qla4xxx: Updates for scsi-misc-2.6
>
>On Thu, 2011-03-17 at 22:49 -0500, Mike Christie wrote:
>> On 03/14/2011 12:23 AM, Vikas Chaudhary wrote:
>> > James,
>> >
>> > Please apply these patches on scsi-misc-2.6 tree.
>> >
>> > Karen Higgins (2):
>> >        qla4xxx: cleanup DDB relogin logic during initialization
>> >        qla4xxx: Prevent other port reinitialization during
>remove_adapter
>> >
>> > Prasanna Mumbai (3):
>> >        qla4xxx: Do not send mbox command if FW is in failed state
>> >        qla4xxx: Do not retry ISP82XX initialization if H/W state is
>failed
>> >        qla4xxx: masking required bits of add_fw_options during
>initialization
>> >
>> > Sarang Radke (1):
>> >        qla4xxx: Use polling mode for disable interrupt mailbox
>completion
>> >
>> > Vikas Chaudhary (7):
>> >        qla4xxx: cleanup qla4xxx_initialize_ddb_list()
>> >        qla4xxx: remove unused ddb flag DF_NO_RELOGIN
>> >        qla4xxx: cleanup function qla4xxx_process_ddb_changed
>> >        qla4xxx: Add support for ql4xmaxqdepth command line parameter
>> >        qla4xxx: add support for ql4xsess_recovery_tmo cmd line param
>> >        qla4xxx: added new function qla4xxx_relogin_all_devices
>> >        qla4xxx: Update driver version to 5.02.00-k6
>> >
>>
>> Patches look ok with updated 06/13 patch. James, Vikas actually sent a
>> couple revisions of 06/13. The final one is here:
>> http://marc.info/?l=linux-scsi&m=130035150917342&w=2
>>
>> I could not compile/checkpatch test the patches, because my
>> mailer/browser keeps replacing = with =D. Other people seem to be able
>> to see it ok, so I think it is problem on my side. Code was reviewed.
>
>I don't think that's entirely your fault.  This entire patch series is
>whitespace damaged.  Vikas, please resubmit with the correct mailer
>settings so it can be applied.

I apologies for inconvenience. Looks like my email client added whitespaces in patch.
I am sending patches again in next email using "git sent-email".

>
>> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
>
>I'll add this to the resubmit, thanks!
>
>James
>
>


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.