From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 3/3] tcm ibmvscsis driver Date: Mon, 21 Mar 2011 16:05:30 -0500 Message-ID: <1300741531.10634.45.camel@mulgrave.site> References: <20110307134033K.fujita.tomonori@lab.ntt.co.jp> <1299508803.12730.1.camel@mulgrave.site> <4D83C78D.5040908@linux.vnet.ibm.com> <20110321100909E.fujita.tomonori@lab.ntt.co.jp> <4D87BC8C.5090104@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from cantor.suse.de ([195.135.220.2]:35364 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235Ab1CUVFk (ORCPT ); Mon, 21 Mar 2011 17:05:40 -0400 In-Reply-To: <4D87BC8C.5090104@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Brian King Cc: FUJITA Tomonori , nab@linux-iscsi.org, linux-scsi@vger.kernel.org On Mon, 2011-03-21 at 16:01 -0500, Brian King wrote: > On 03/20/2011 08:09 PM, FUJITA Tomonori wrote: > > Thanks for the testings, > > > > On Fri, 18 Mar 2011 15:58:53 -0500 > > Brian King wrote: > > > >> On 03/07/2011 08:40 AM, James Bottomley wrote: > >>> On Mon, 2011-03-07 at 13:41 +0900, FUJITA Tomonori wrote: > >>>> On Sat, 12 Feb 2011 14:27:26 -0600 > >>>> James Bottomley wrote: > >>>> > >>>>>> Disregard my previous comment. It looks like current client should handle reservations > >>>>>> just fine without any further changes. > >>>>> > >>>>> So is that an ack for putting this in scsi-misc ... or did you want to > >>>>> do more testing first? > >>>> > >>>> Ping, > >>>> > >>>> Brian, James, can we merge this during the next merge window? > >>> > >>> I'm still waiting for an ack from Brian. > >> > >> Sorry for the delay... I've got this loaded in the lab and have managed to oops > >> a couple times. The first one was during shutdown, which I wasn't able to collect > >> any data for. The most recent occurred when a client was trying to login for the > >> first time: > > > > You mean that the kernel crashes every time when a client logs in? > > I think the crash I was seeing when the client logs in was just due to the fact that > I had things misconfigured. It took me a bit to figure out the configfs stuff. Didn't > realize at first I had to go off and manually create a lot of the configfs layout > described in the wiki page. Once I did that, I was able to get a LUN to successfully > report in on the client side. I'll start pounding on this a bit and see how things > hold up. Hmm, so that still indicates the error handling is screwed at this point. That, I suppose, should be fixable (plus being a fix, it's merge window exempt). Do you want this in now, or wait until next merge window? James