From: James Bottomley <James.Bottomley@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
Matthew Wilcox <willy@linux.intel.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] SCSI: Make cmd_serial_number an atomic
Date: Sun, 03 Apr 2011 07:14:54 -0500 [thread overview]
Message-ID: <1301832894.2631.2.camel@mulgrave.site> (raw)
In-Reply-To: <20110403110057.GC3872@infradead.org>
On Sun, 2011-04-03 at 07:00 -0400, Christoph Hellwig wrote:
> On Sat, Apr 02, 2011 at 03:02:40PM -0600, Matthew Wilcox wrote:
> > Fair enough, but you're making the perfect the enemy of the good.
> > How about putting this patch in for now (since it harms nothing), and
> > then it'll all go away when you delete cmd_serial_number?
>
> If you change it anyway for mpt2sas just keep the atomic counter in
> it's local structures. Or even better verify with LSI if the
> serial_number check can't simply be removed entirely, which I think it
> could.
Also I'm not really sure atomic counter conversion is the correct thing
to do. Someone from intel said it would perform worse than the current
spinlock based serial number the last time we discussed the conversion
(converting it to atomic was my first thought at the time).
James
next prev parent reply other threads:[~2011-04-03 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 20:20 [PATCH 1/3] SCSI: Make cmd_serial_number an atomic Matthew Wilcox
2011-04-02 13:36 ` Christoph Hellwig
2011-04-02 13:51 ` James Bottomley
2011-04-02 18:10 ` Jeff Garzik
2011-04-02 21:02 ` Matthew Wilcox
2011-04-03 11:00 ` Christoph Hellwig
2011-04-03 12:14 ` James Bottomley [this message]
2011-04-03 13:15 ` Matthew Wilcox
2011-04-03 13:33 ` Christoph Hellwig
2011-04-03 19:54 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301832894.2631.2.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).