From: "Bhanu Prakash Gollapudi" <bprakash@broadcom.com>
To: linux-scsi@vger.kernel.org, devel@open-fcoe.org
Cc: Nithin Nayak Sujir <nsujir@broadcom.com>,
Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Subject: [PATCH 2/5] bnx2fc: Release the reference to hba only after the interface is destroyed
Date: Mon, 25 Apr 2011 12:30:07 -0700 [thread overview]
Message-ID: <1303759810-22570-2-git-send-email-bprakash@broadcom.com> (raw)
In-Reply-To: <1303759810-22570-1-git-send-email-bprakash@broadcom.com>
From: Nithin Nayak Sujir <nsujir@broadcom.com>
Prematurely decrementing the reference may lead to cmd_mgr becoming NULL with
the cmds are still active.
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 8fb9b6e..734d8c1 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -1370,8 +1370,6 @@ static void bnx2fc_if_destroy(struct fc_lport *lport)
/* Free existing transmit skbs */
fcoe_clean_pending_queue(lport);
- bnx2fc_interface_put(hba);
-
/* Free queued packets for the receive thread */
bnx2fc_clean_rx_queue(lport);
@@ -1399,6 +1397,8 @@ static void bnx2fc_if_destroy(struct fc_lport *lport)
/* Release Scsi_Host */
scsi_host_put(lport->host);
+
+ bnx2fc_interface_put(hba);
}
/**
--
1.7.0.6
next prev parent reply other threads:[~2011-04-25 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 19:30 [PATCH 1/5] scsi_transport_fc: Fix deadlock during fc_remove_host Bhanu Prakash Gollapudi
2011-04-25 19:30 ` Bhanu Prakash Gollapudi [this message]
2011-04-25 22:49 ` [PATCH 2/5] bnx2fc: Release the reference to hba only after the interface is destroyed Shyam_Iyer
2011-04-25 23:15 ` Bhanu Prakash Gollapudi
2011-04-26 4:09 ` Shyam_Iyer
2011-04-26 4:10 ` Shyam_Iyer
2011-04-25 19:30 ` [PATCH 3/5] bnx2fc: call scsi_done if session goes to not ready from ready Bhanu Prakash Gollapudi
2011-04-25 19:30 ` [PATCH 4/5] bnx2fc: Do not use HBA_DBG macro when lport is not available Bhanu Prakash Gollapudi
2011-04-25 19:30 ` [PATCH 5/5] bnx2fc: increase cleanup wait time Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303759810-22570-2-git-send-email-bprakash@broadcom.com \
--to=bprakash@broadcom.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox