linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: vikas.chaudhary@qlogic.com
To: James.Bottomley@suse.de, michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, vikas.chaudhary@qlogic.com,
	lalit.chandivade@qlogic.com, ravi.anand@qlogic.com,
	Prasanna Mumbai <prasanna.mumbai@qlogic.com>
Subject: [PATCH 04/10] qla4xxx: Complete the cmd if sense_len is zero
Date: Tue, 17 May 2011 23:17:06 -0700	[thread overview]
Message-ID: <1305699432-13225-5-git-send-email-vikas.chaudhary@qlogic.com> (raw)
In-Reply-To: <1305699432-13225-1-git-send-email-vikas.chaudhary@qlogic.com>

From: Prasanna Mumbai <prasanna.mumbai@qlogic.com>

Complete the cmd if sense length is zero. For cases where sense
data spans across multiple iocb's by FW, we need to hold on to the
I/O (ha->status_srb != NULL) till we have processed them all and
copied the sense data from internal buffer to scsi_cmd sense buffer.

Signed-off-by: Prasanna Mumbai <prasanna.mumbai@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/qla4xxx/ql4_isr.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_isr.c b/drivers/scsi/qla4xxx/ql4_isr.c
index 67d6651..0e72921 100644
--- a/drivers/scsi/qla4xxx/ql4_isr.c
+++ b/drivers/scsi/qla4xxx/ql4_isr.c
@@ -25,9 +25,14 @@ static void qla4xxx_copy_sense(struct scsi_qla_host *ha,
 
 	memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
 	sense_len = le16_to_cpu(sts_entry->senseDataByteCnt);
-	if (sense_len == 0)
+	if (sense_len == 0) {
+		DEBUG2(ql4_printk(KERN_INFO, ha, "scsi%ld:%d:%d:%d: %s:"
+				  " sense len 0\n", ha->host_no,
+				  cmd->device->channel, cmd->device->id,
+				  cmd->device->lun, __func__));
+		ha->status_srb = NULL;
 		return;
-
+	}
 	/* Save total available sense length,
 	 * not to exceed cmd's sense buffer size */
 	sense_len = min_t(uint16_t, sense_len, SCSI_SENSE_BUFFERSIZE);
-- 
1.7.3.2


  parent reply	other threads:[~2011-05-18  6:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18  6:17 [PATCH 00/10] qla4xxx: Updates for scsi-misc-2.6 vikas.chaudhary
2011-05-18  6:17 ` [PATCH 01/10] qla4xxx: update function qla4xxx_isr_decode_mailbox() vikas.chaudhary
2011-05-18  6:17 ` [PATCH 02/10] qla4xxx: Updated the reset sequence for ISP82xx vikas.chaudhary
2011-05-18  6:17 ` [PATCH 03/10] qla4xxx: Dump HW/FW reg to figure out what caused FW to be hung for ISP82XX vikas.chaudhary
2011-05-18  6:17 ` vikas.chaudhary [this message]
2011-05-18  6:17 ` [PATCH 05/10] qla4xxx: Don't process mbx interrupt unconditionally vikas.chaudhary
2011-05-18  6:17 ` [PATCH 06/10] qla4xxx: Don't check FW alive if ISP82XX reset is in progress vikas.chaudhary
2011-05-18  6:17 ` [PATCH 07/10] qla4xxx: Remove AF_DPC_SCHEDULED flag from ha vikas.chaudhary
2011-05-18  6:17 ` [PATCH 08/10] qla4xxx: Remove host_lock in queuecommand function vikas.chaudhary
2011-05-18  6:17 ` [PATCH 09/10] qla4xxx: Added vendor specific sysfs attributes vikas.chaudhary
2011-05-18  6:17 ` [PATCH 10/10] qla4xxx: Update driver version to 5.02.00-k7 vikas.chaudhary
2011-05-18 18:45 ` [PATCH 00/10] qla4xxx: Updates for scsi-misc-2.6 Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305699432-13225-5-git-send-email-vikas.chaudhary@qlogic.com \
    --to=vikas.chaudhary@qlogic.com \
    --cc=James.Bottomley@suse.de \
    --cc=lalit.chandivade@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=prasanna.mumbai@qlogic.com \
    --cc=ravi.anand@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).