From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-scsi@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
dmilburn@redhat.com, jack_wang@usish.com,
Jeff Skirvin <jeffrey.d.skirvin@intel.com>,
yuxiangl@marvell.com, hch@lst.de
Subject: Re: [RFC PATCH] isci: filter broadcast change notifications during SMP phy resets
Date: Mon, 27 Jun 2011 11:02:34 -0500 [thread overview]
Message-ID: <1309190554.459.3.camel@mulgrave> (raw)
In-Reply-To: <4E0894EC.2010509@suse.de>
On Mon, 2011-06-27 at 16:34 +0200, Hannes Reinecke wrote:
> On 06/24/2011 09:48 PM, Dan Williams wrote:
> > From: Jeff Skirvin<jeffrey.d.skirvin@intel.com>
> >
> > When resetting a sata device in the domain we have seen occasions where
> > libsas prematurely marks a device gone in the time it takes for the
> > device to re-establish the link. This plays badly with software raid
> > arrays. Other libsas drivers have non-uniform delays in their reset
> > handlers to try to cover this condition, but not sufficient to close the
> > hole. Given that a sata device can take many seconds to recover we
> > filter bcns and poll for the device reattach state before notifying
> > libsas that the port needs the domain to be rediscovered. Once this has
> > been proven out at the lldd level we can think about uplevelling this
> > feature to a common implementation in libsas.
> >
> That's the second time something like this have come up now.
> Wouldn't it makes sense to implement something like the dev_loss_tmo
> mechanism with have for FC? That should cover this situation nicely ...
It's certainly what we agreed to at LSF, yes, so it looks like a good
idea.
James
prev parent reply other threads:[~2011-06-27 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 19:48 [RFC PATCH] isci: filter broadcast change notifications during SMP phy resets Dan Williams
2011-06-27 14:34 ` Hannes Reinecke
2011-06-27 14:49 ` Brian King
2011-06-27 15:59 ` Douglas Gilbert
2011-06-27 16:27 ` Dan Williams
2011-06-27 16:02 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309190554.459.3.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmilburn@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack_wang@usish.com \
--cc=jeffrey.d.skirvin@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox