From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kgudipat@brocade.com
Cc: linux-scsi@vger.kernel.org, huangj@brocade.com,
adapter_linux_open_src_team@brocade.com
Subject: Re: [PATCH 08/15] bfa: Extend BSG interface.
Date: Wed, 29 Jun 2011 17:21:04 -0500 [thread overview]
Message-ID: <1309386064.13937.18.camel@mulgrave> (raw)
In-Reply-To: <1308972315-8296-1-git-send-email-kgudipat@brocade.com>
On Fri, 2011-06-24 at 20:25 -0700, kgudipat@brocade.com wrote:
> int
> bfad_iocmd_ioc_get_pcifn_cfg(struct bfad_s *bfad, void *cmd)
> {
> @@ -511,27 +986,87 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned
> int cmd, void *iocmd,
> int rc = EINVAL;
This is nastily counterintuitive. I know it's compensated for by the
return -rc;
But you're creating code confusion here. Some of your routines now have
a positive error return and some negative. Can't you just keep it
negative as is the kernel convention?
James
next prev parent reply other threads:[~2011-06-29 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 3:25 [PATCH 08/15] bfa: Extend BSG interface kgudipat
2011-06-29 22:21 ` James Bottomley [this message]
2011-06-29 22:38 ` Krishna Gudipati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309386064.13937.18.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=huangj@brocade.com \
--cc=kgudipat@brocade.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox