From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Chad Dupuis <chad.dupuis@qlogic.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0.
Date: Thu, 14 Jul 2011 12:37:36 -0500 [thread overview]
Message-ID: <1310665056.15805.2.camel@mulgrave> (raw)
In-Reply-To: <CA4476B1.21CBD%giridhar.malavali@qlogic.com>
On Thu, 2011-07-14 at 10:36 -0700, Giridhar Malavali wrote:
>
> >>
>
> >On Thu, 2011-07-14 at 10:07 -0700, giridhar.malavali@qlogic.com wrote:
> >> From: Giridhar Malavali <giridhar.malavali@qlogic.com>
> >>
> >> James,
> >>
> >> Please apply these patches.
> >>
> >> The patch 1/3 has couple of warnings w.r.t KERN_facility level with
> >>printk.
> >>
> >> WARNING: printk() should include KERN_ facility level
> >>
> >> Using KERN facility in printk will print each buffer information in new
> >>line causing
> >> unreadable log messages.
> >>
> >> Here is an example
> >>
> >> With KERN facility
> >> Mar 23 10:05:37 linux-dcaw kernel: qla2xxx [0000:18:00.6]4:1102:
> >> Mar 23 10:05:37 linux-dcaw kernel: 42
> >> Mar 23 10:05:37 linux-dcaw kernel:
> >> Mar 23 10:05:37 linux-dcaw kernel: 00
> >>
> >> Without KERN facility
> >> Mar 21 13:07:35 linux-dcaw kernel: qla2xxx [0000:18:00.7]37:1102: 48
> >>00 00 00 5b f2 00
> >>
> >> Hope this should be fine since this is not an error.
> >>
> >> -- Giridhar
> >> Saurav Kashyap (3):
> >> qla2xxx: Basic infrastructure for dynamic logging.
> >> qla2xxx: Code changes to support new dynamic logging infrastructure.
> >
> >This patch is missing (for the second time). It's either too big or is
> >getting caught in vger's spam filters somehow.
>
> Thanks for the information. I will resubmit the patches breaking them
> further. I think the patch is too big.
OK, our limit is somewhere around 200k I think. Just split it into
2a,2b etc ... don't worry about bisectability, I'll recombine them all
on import.
James
next prev parent reply other threads:[~2011-07-14 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 17:07 [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0 giridhar.malavali
2011-07-14 17:07 ` [PATCH 1/3] qla2xxx: Basic infrastructure for dynamic logging giridhar.malavali
2011-07-14 17:07 ` [PATCH 3/3] qla2xxx: Cleanup of previous infrastructure giridhar.malavali
2011-07-14 17:29 ` [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0 James Bottomley
2011-07-14 17:36 ` Giridhar Malavali
2011-07-14 17:37 ` James Bottomley [this message]
2011-07-14 19:13 ` Giridhar Malavali
2011-07-14 17:47 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2011-07-14 6:30 giridhar.malavali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310665056.15805.2.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=andrew.vasquez@qlogic.com \
--cc=chad.dupuis@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox