From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, torvalds@linux-foundation.org,
stable@kernel.org, Dan Williams <dan.j.williams@intel.com>
Subject: Re: Linux 3.0 STILL dies on USB device hotplug - please merge fix ASAP
Date: Fri, 22 Jul 2011 15:52:28 -0400 [thread overview]
Message-ID: <1311364348.7153.3.camel@mulgrave> (raw)
In-Reply-To: <20110722170214.GR8006@one.firstfloor.org>
On Fri, 2011-07-22 at 19:02 +0200, Andi Kleen wrote:
> Hi,
>
> 3.0 still oopses and dies immediately on USB device hot unplug.
> The same problem also triggered with SAS device according to Dan.
>
> There was a lot of debugging on this a few weeks back and Alan Stern
> posted a SCSI layer patch that fixed the problem (for both USB
> and SAS):
>
> http://68.183.106.108/lists/linux-usb/msg49001.html
>
> But for some reason that patch didn't make it into 3.0 and 3.0 still
> happily oopses as the RC*s.
>
> Can you please merge this patch ASAP? This should also go to stable.
>
> At least for me it makes pure 3.0 very risky to use, because these USB
> hotunplug events are not uncommon and I end up with a dead machine.
Like I said at the time, the patch is wrong because of the relocation of
the queue teardown. I posted a corrected version, but did anyone test?
Anyway, I merged it on the grounds that it worked for me, but if you
could confirm with linux-next, that would be great (I'll send the pull
request shortly, since it now needs to go via the merge window and I'm
currently in mid journey to Russia.
James
next prev parent reply other threads:[~2011-07-22 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 17:02 Linux 3.0 STILL dies on USB device hotplug - please merge fix ASAP Andi Kleen
2011-07-22 18:23 ` Jonathan McDowell
2011-07-22 19:52 ` James Bottomley [this message]
2011-07-22 20:19 ` Alan Stern
2011-07-22 21:44 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311364348.7153.3.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=andi@firstfloor.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox