From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Cc: linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu,
mchan@broadcom.com, devel@open-fcoe.org
Subject: Re: [PATCH 02/12] bnx2fc: Introduce interface structure for each vlan interface
Date: Tue, 26 Jul 2011 13:41:42 +0400 [thread overview]
Message-ID: <1311673302.17353.21.camel@mulgrave> (raw)
In-Reply-To: <1309242664-27252-3-git-send-email-bprakash@broadcom.com>
On Mon, 2011-06-27 at 23:30 -0700, Bhanu Prakash Gollapudi wrote:
> Currently, bnx2fc has a hba structure that can work with only a single vlan
> interface. When there is a change in vlan id, it does not have the capability
> to switch to different vlan interface. To solve this problem, a new structure
> called 'interface' has been introduced, and each hba can now have multiple
> interfaces, one per vlan id.
>
> Most of the patch is a moving the interface specific fields from hba to the
> interface structure, and appropriately modifying the dereferences. A list of
> interfaces (if_list) is maintained along with adapter list. During a create
> call, the interface structure is allocated and added to if_list and deleted &
> freed on a destroy call. Link events are propogated to all interfaces
> belonging to the hba.
Best I can tell, the upstream prerequisites are satisfied, but I still
can't apply this because of a conflicting upstream patch:
commit 415199f2bd977fa4065d4e836b4b7543f7993bc3
Author: Michael Chan <mchan@broadcom.com>
Date: Wed Jul 20 14:55:24 2011 +0000
cnic: Add VLAN ID as a parameter during netevent upcall
Which actually introduces an explicit failure return for vlans. Could
you respin from 2 on to sort this out?
Thanks,
James
next prev parent reply other threads:[~2011-07-26 9:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 6:30 [PATCH 00/12] bnx2fc: Version 1.0.4 Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 03/12] bnx2fc: Enable REC & CONF support for the session Bhanu Prakash Gollapudi
[not found] ` <1309242664-27252-1-git-send-email-bprakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2011-06-28 6:30 ` [PATCH 01/12] bnx2fc: Replace printks with KERN_ALERT to KERN_ERR/KERN_INFO Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 02/12] bnx2fc: Introduce interface structure for each vlan interface Bhanu Prakash Gollapudi
2011-07-26 9:41 ` James Bottomley [this message]
2011-07-26 16:13 ` Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 04/12] bnx2fc: Support 'sequence cleanup' task Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 05/12] bnx2fc: REC/SRR link service request and response handling Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 06/12] bnx2fc: Handle REC_TOV error code from firmware Bhanu Prakash Gollapudi
2011-06-28 6:30 ` [PATCH 07/12] bnx2fc: HSI changes for tape Bhanu Prakash Gollapudi
2011-06-28 6:31 ` [PATCH 08/12] bnx2fc: Enable support for sequence level error recovery Bhanu Prakash Gollapudi
2011-06-28 6:31 ` [PATCH 09/12] bnx2fc: hold tgt lock when calling cmd_release Bhanu Prakash Gollapudi
2011-06-28 6:31 ` [PATCH 10/12] bnx2fc: Do not arm CQ when there are no CQEs Bhanu Prakash Gollapudi
2011-06-28 6:31 ` [PATCH 11/12] bnx2fc: Tx BDs cache in write tasks Bhanu Prakash Gollapudi
2011-06-28 6:31 ` [PATCH 12/12] bnx2fc: Update copyright and bump version to 1.0.4 Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311673302.17353.21.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=bprakash@broadcom.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox