From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Cc: linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu,
mchan@broadcom.com, devel@open-fcoe.org
Subject: Re: [PATCH RESEND 03/11] bnx2fc: Support 'sequence cleanup' task
Date: Wed, 27 Jul 2011 15:40:57 +0400 [thread overview]
Message-ID: <1311766857.5029.1.camel@mulgrave> (raw)
In-Reply-To: <1311717109-14077-4-git-send-email-bprakash@broadcom.com>
On Tue, 2011-07-26 at 14:51 -0700, Bhanu Prakash Gollapudi wrote:
> For the devices that support sequence level error recovery, based on the REC
> response, the firmware has to be informed about the offset from which the
> retransmission should happen. Driver initiates sequence cleanup task to
> firmware so that the firmware can program the task. Upon the sequence cleanup
> completion, SRR is issued to retransmit the sequence.
>
> Signed-off-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc.h | 10 ++++
> drivers/scsi/bnx2fc/bnx2fc_hwi.c | 97 ++++++++++++++++++++++++++++++++++
> drivers/scsi/bnx2fc/bnx2fc_io.c | 106 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 213 insertions(+), 0 deletions(-)
Well, I got another two patches include, but this one doesn't compile:
CC [M] drivers/scsi/bnx2fc/bnx2fc_io.o
drivers/scsi/bnx2fc/bnx2fc_io.c: In function
‘bnx2fc_initiate_seq_cleanup’:
drivers/scsi/bnx2fc/bnx2fc_io.c:987:8: error: ‘struct bnx2fc_els_cb_arg’
has no member named ‘r_ctl’
drivers/scsi/bnx2fc/bnx2fc_io.c:988:8: error: ‘struct bnx2fc_els_cb_arg’
has no member named ‘offset’
drivers/scsi/bnx2fc/bnx2fc_io.c: In function
‘bnx2fc_process_seq_cleanup_compl’:
drivers/scsi/bnx2fc/bnx2fc_io.c:1235:21: error: ‘struct
bnx2fc_els_cb_arg’ has no member named ‘offset’
drivers/scsi/bnx2fc/bnx2fc_io.c:1236:29: error: ‘struct
bnx2fc_els_cb_arg’ has no member named ‘r_ctl’
drivers/scsi/bnx2fc/bnx2fc_io.c:1252:2: error: implicit declaration of
function ‘bnx2fc_send_srr’
make[1]: *** [drivers/scsi/bnx2fc/bnx2fc_io.o] Error 1
make: *** [drivers/scsi/bnx2fc/bnx2fc.ko] Error 2
I assume it has to be combined with one of the other patches to make a
bisectable unit?
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-27 11:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 21:51 [PATCH RESEND 00/11] bnx2fc: Version 1.0.4 Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 01/11] bnx2fc: Introduce interface structure for each vlan interface Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 02/11] bnx2fc: Enable REC & CONF support for the session Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 03/11] bnx2fc: Support 'sequence cleanup' task Bhanu Prakash Gollapudi
2011-07-27 11:40 ` James Bottomley [this message]
2011-07-27 18:13 ` Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 04/11] bnx2fc: REC/SRR link service request and response handling Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 05/11] bnx2fc: Handle REC_TOV error code from firmware Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 06/11] bnx2fc: HSI changes for tape Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 07/11] bnx2fc: Enable support for sequence level error recovery Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 08/11] bnx2fc: hold tgt lock when calling cmd_release Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 09/11] bnx2fc: Do not arm CQ when there are no CQEs Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 10/11] bnx2fc: Tx BDs cache in write tasks Bhanu Prakash Gollapudi
2011-07-26 21:51 ` [PATCH RESEND 11/11] bnx2fc: Update copyright and bump version to 1.0.4 Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311766857.5029.1.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=bprakash@broadcom.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox